feat:added rabbitmq support #142
Conversation
|
Hey @Siddharth9890 nice work, can you add some specs to the publisher and to the subscriber? |
Gemfile
Outdated
| gem "bunny" | ||
|
|
||
|
|
There was a problem hiding this comment.
| gem "bunny" | |
| # Ruby client for RabbitMQ [https://github.com/ruby-amqp/bunny] | |
| gem "bunny" |
Gemfile
Outdated
| gem "bunny-mock" | ||
|
|
There was a problem hiding this comment.
Duplicated
| gem "bunny-mock" |
spec/rabbitmq/publisher_spec.rb
Outdated
| @@ -0,0 +1,28 @@ | |||
| # spec/services/rabbitmq_publisher_spec.rb | |||
There was a problem hiding this comment.
Can you move this file for this path spec/services/*?
spec/rabbitmq/publisher_spec.rb
Outdated
| let(:rabbitmq_url) { 'amqp://test:test@rabbitmq:5672/' } | ||
|
|
||
|
|
||
| it 'should publish messages to queues' do |
There was a problem hiding this comment.
Can you fix the indentation of this file? 🙏🏻
Siddharth9890
force-pushed
the
feat/add-rabit-mq
branch
from
389aa12 to
325fd2f
Compare
|
Hey i tried fixing the linting but i am not sure how to check linting locally in ruby so if there are linting errors please guide me on how to check locally |
You can run locally: |
|
@leonardobrito done |
Hey @Siddharth9890 looks like we still having some issues with linters 😔, can you take a look again? |
|
hey @leonardobrito i have skip check for linting for the test it is false positive so it will give a warning on internet i was unable to find a solution hence a workaround |
The issue with the lint is because you have more than 1 expectation inside the test case. To solve this you will need to have a separated |
Yes sure, @Siddharth9890 please update the rubocop config to allow it |
Issue #110
The rabbitmq instance is working as well using docker compose
@edimossilva