Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(tests): Fix conclusion status and badge pushing #10013

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

lucasssvaz
Copy link
Collaborator

@lucasssvaz lucasssvaz commented Jul 11, 2024

Description of Change

Fixes possible CI error when the badge files are identical and there is nothing to push.
Also propagates the conclusion status throughout the workflows.

Copy link
Contributor

github-actions bot commented Jul 11, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 6c0ae93

Copy link
Contributor

github-actions bot commented Jul 11, 2024

Test Results

 56 files  ±0   56 suites  ±0   5m 1s ⏱️ +6s
 21 tests ±0   21 ✅ ±0  0 💤 ±0  0 ❌ ±0 
135 runs  ±0  135 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6c0ae93. ± Comparison against base commit 4b7b5d3.

♻️ This comment has been updated with latest results.

@lucasssvaz lucasssvaz added Status: Pending Merge Pull Request is ready to be merged and removed Status: Pending Merge Pull Request is ready to be merged labels Jul 11, 2024
@lucasssvaz lucasssvaz changed the title ci(badge): Push only when changes happened to badge ci(tests): Fix conclusion status and badge pushing Jul 11, 2024
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Jul 15, 2024
@me-no-dev me-no-dev merged commit e54fb9e into espressif:master Jul 15, 2024
40 checks passed
@lucasssvaz lucasssvaz deleted the bugfix/badge branch July 15, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants