-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDMMC: Fix example code #10035
SDMMC: Fix example code #10035
Conversation
The setPins() function obviously comes from the SD_MMC lib. Not prepending that lib, this code won't compile. Signed-off-by: Martin Hübner <martin.hubner@web.de>
👋 Hello Akira25, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Hello @Akira25, thanks for the fix, we will review it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test Results 56 files 56 suites 4m 50s ⏱️ Results for commit 0ce741a. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Description of Change
The setPins() function obviously comes from the SD_MMC lib. Not prepending that lib, this code won't compile.
Tests scenarios
Uncomment code section and compile code.
I have tested my Pull Request on Arduino-esp32 core v2.0.16 with ESP32-S3-devkitc1 Board.
Related links
None. I found that recently by using the example.