Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDMMC: Fix example code #10035

Merged
merged 2 commits into from
Jul 16, 2024
Merged

SDMMC: Fix example code #10035

merged 2 commits into from
Jul 16, 2024

Conversation

Akira25
Copy link
Contributor

@Akira25 Akira25 commented Jul 15, 2024

Description of Change

The setPins() function obviously comes from the SD_MMC lib. Not prepending that lib, this code won't compile.

Tests scenarios

Uncomment code section and compile code.

I have tested my Pull Request on Arduino-esp32 core v2.0.16 with ESP32-S3-devkitc1 Board.

Related links

None. I found that recently by using the example.

The setPins() function obviously comes from the SD_MMC lib. Not prepending
that lib, this code won't compile.

Signed-off-by: Martin Hübner <martin.hubner@web.de>
@CLAassistant
Copy link

CLAassistant commented Jul 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jul 15, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "SDMMC: Fix example code":
    • summary looks too short
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello Akira25, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 0ce741a

@VojtechBartoska VojtechBartoska added the Type: Example Issue is related to specific example. label Jul 16, 2024
@VojtechBartoska VojtechBartoska added the Status: Review needed Issue or PR is awaiting review label Jul 16, 2024
@VojtechBartoska
Copy link
Collaborator

Hello @Akira25, thanks for the fix, we will review it soon.

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jul 16, 2024
Copy link
Contributor

github-actions bot commented Jul 16, 2024

Test Results

 56 files   56 suites   4m 50s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
135 runs  135 ✅ 0 💤 0 ❌

Results for commit 0ce741a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32
ExampleFLASHRAMFLASHRAM
SD_MMC/examples/SDMMC_Test0000

@me-no-dev me-no-dev merged commit e850afb into espressif:master Jul 16, 2024
40 checks passed
@Akira25 Akira25 deleted the fix_sdmmc branch July 16, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: Example Issue is related to specific example.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants