-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled the onboard ceramic antenna by default when creating a new project with XIAO_ESP32C6 #10066
Conversation
👋 Hello Cincinnatu, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Hello @Cincinnatu, can you please provide some description about the change and also add some related links? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comment is wrong. Correct is //use onboard antenna
The code is not needed at all, since using onboard antenna is default (without any setup). Only needed when the extern antenna should be activated.
Due to the hardware design of XIAO_ESP32C6, the WIFI antenna will not be turned on by default during use. Some of our users may not know how to turn on the WIFI by themselves, therefore, so I have submitted this PR. |
Sure, I'll add it later. |
So the behaviour described how it works is wrong at the Web page! |
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
I would suggest adding the following defines to #define useInternalAntenna() digitalWrite(WIFI_ANT_CONFIG, LOW)
#define useExternalAntenna() digitalWrite(WIFI_ANT_CONFIG, HIGH) Then maybe that to be documented in the board web page. Is there a case where the WiFi should not be enabled? |
You never know all uses cases. If it is possible to switch off, there will be probably a use case found for. |
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
Please describe your proposed Pull Request and it's impact.
Tests scenarios
Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)
Related links
Please provide links to related issue, PRs etc.
(eg. Closes #number of issue)