feat: Print chip features bitfield #10080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prints the value of the chip features bitfield to printChipInfo() to facilitate debugging.
👋 Hello Xylopyrographer, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 56 files - 83 56 suites - 83 4m 58s ⏱️ - 1h 37m 54s Results for commit 6db3430. ± Comparison against base commit f5be003. This pull request removes 9 tests.♻️ This comment has been updated with latest results. |
|
thanks for the PR @Xylopyrographer, we will review it soon. |
|
Question is what does this help if the bits are examined in the following lines? This will just print a meaningless (to the users and us) hex, that we would need to examine anyway. Do you mean that there might be bits not documented? |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
VojtechBartoska
added
Resolution: Awaiting response
|
@Xylopyrographer any comments? Thanks |
So this stems from #9974 where the chip report from a board using an ESP32-S3FH4R2 fails to report that the chip has both on-board flash and PSRAM. To help diagnose further, I had to add the raw chip features dump. Debugging and diagnostic tools should report accurately, this demonstrates a case where something is amiss. It would also be useful should new silicon be ahead of the chip report as it could be used as a check and yes, show undocumented features. As for interpretation, the bits are enumerated and can be checked (albeit with a bit more digging) but at least the base information is there to investigate further if needed. FWIW, haven't yet carried the investigation into the above error further. Not reported in IDF 4.4? Definition of "embedded" means something else? Does it show only for ESP32 modules? |
me-no-dev
added
Status: Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds printing the value of the chip features bitfield to printChipInfo() to facilitate debugging.
Tests scenarios
Tested with:
Related links
None