Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wifi): Allow setting minimum time for wifi scan #10083

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR add a function to WiFiScan class for setting the minimum active scan time.
This allows complete timing customisation for Wifi scan.

void setScanActiveMinTime(uint32_t ms);

The default value is 100 to keep compatibility with previous code.

WiFi scan timing parameters explained:

min=0, max=0: scan dwells on each channel for 120 ms.
min>0, max=0: scan dwells on each channel for 120 ms.
min=0, max>0: scan dwells on each channel for max ms.
min>0, max>0: the minimum time the scan dwells on each channel is min ms. If no AP is found during this time frame, the scan switches to the next channel. Otherwise, the scan dwells on the channel for max ms.

Tests scenarios

Locally

Related links

Closes #10082

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: WiFi Issue related to WiFi label Jul 29, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jul 29, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Review needed Issue or PR is awaiting review label Jul 29, 2024
Copy link
Contributor

github-actions bot commented Jul 29, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9df5954

Copy link
Contributor

github-actions bot commented Jul 29, 2024

Test Results

 56 files   56 suites   4m 46s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
135 runs  135 ✅ 0 💤 0 ❌

Results for commit 9df5954.

♻️ This comment has been updated with latest results.

@VojtechBartoska VojtechBartoska added this to the 3.0.4 milestone Jul 29, 2024
Copy link
Contributor

github-actions bot commented Jul 29, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +40.000.00000.000.00
ESP32S2💚 -4⚠️ +200.000.000⚠️ +160.00⚠️ +0.04
ESP32C30⚠️ +100.000.00000.000.00
ESP32C60⚠️ +20.000.00000.000.00
ESP320⚠️ +240.000.000⚠️ +160.00⚠️ +0.03
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
WiFi/examples/FTM/FTM_Initiator0000000000
WiFi/examples/FTM/FTM_Responder0000000000
WiFi/examples/SimpleWiFiServer0000000000
WiFi/examples/WPS0000000000
WiFi/examples/WiFiAccessPoint0000000000
WiFi/examples/WiFiBlueToothSwitch00--000000
WiFi/examples/WiFiClient0000000000
WiFi/examples/WiFiClientBasic⚠️ +40⚠️ +40000000
WiFi/examples/WiFiClientConnect0000000000
WiFi/examples/WiFiClientEnterprise0000000000
WiFi/examples/WiFiClientEvents0000000000
WiFi/examples/WiFiClientStaticIP0000000000
WiFi/examples/WiFiIPv60000000000
WiFi/examples/WiFiMulti⚠️ +40⚠️ +40000000
WiFi/examples/WiFiMultiAdvanced⚠️ +40⚠️ +20⚠️ +16⚠️ +10000⚠️ +24⚠️ +16
WiFi/examples/WiFiScan⚠️ +40💚 -40000000
WiFi/examples/WiFiScanAsync⚠️ +40⚠️ +40000000
WiFi/examples/WiFiScanDualAntenna⚠️ +40⚠️ +4000⚠️ +2000
WiFi/examples/WiFiScanTime----------
WiFi/examples/WiFiSmartConfig0000000000
WiFi/examples/WiFiTelnetToSerial⚠️ +40⚠️ +40⚠️ +200000
WiFi/examples/WiFiUDPClient0000000000

@lucasssvaz lucasssvaz added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jul 29, 2024
@me-no-dev me-no-dev merged commit 9065342 into espressif:master Jul 31, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: WiFi Issue related to WiFi Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the amount of time it scans for a wifi signals
4 participants