fix(uart): Sets XTAL as clock source for uart #10087
Merged
+22
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C6 and H2 have problems after returning from light sleep. The baud rate seems to be off when APB is used as clock source. This fix solves the issue using a steady clock source.
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
SuGlider
commented
Jul 30, 2024
Adds C2 in the XTAL list.
Test Results112 files - 27 112 suites - 27 24m 30s ⏱️ - 1h 17m 59s Results for commit 854111f. ± Comparison against base commit 6244d9a. This pull request removes 5 tests.♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
This is creating some issues in the existing implementation: https://github.com/espressif/arduino-esp32/actions/runs/10169622396/job/28128857075#step:11:230 |
P-R-O-C-H-Y
previously approved these changes
Jul 31, 2024
|
@SuGlider HW tests on UART is failing on the baud rate change test PTAL. |
Fixes the functions for reading/writing UART baudrate by using IDF functions instead of HAL/LL.
|
@lucasssvaz | @P-R-O-C-H-Y |
Fixes the baudrate for ESP32 and ESP32-S2 when the baud rate is higher than 1MHz. REF_TICK is just 2MHZ and can handle up to 1MHZ baudrate.
Default RxTimeout changed to the minimum = 1. When TICK_REF is used as clock source, this is mandatory,
me-no-dev
approved these changes
Aug 1, 2024
|
@P-R-O-C-H-Y PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
C6 and H2 UART baud rate has problems after returning from light sleep.
The baud rate seems to be off when APB is used as clock source.
This fix solves the issue using a steady clock source for all SoC that can handle XTAL as UART clock source.
Tests scenarios
Using S3, C3, C6 and H2 using the code suggested in #10065
Related links
Fixes #10065