Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): Update RainMaker examples to work with ESP32C6 #10096

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR updates the RainMaker examples to work with ESP32C6.
Also enabled C6 in the CI for the RM examples.

Tests scenarios

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jul 31, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added Area: Rainmaker Issue is related to ESP Rainmaker. Type: Example Issue is related to specific example. labels Jul 31, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.0.4 milestone Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3c6d9a8

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Test Results

 56 files   56 suites   5m 22s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
135 runs  135 ✅ 0 💤 0 ❌

Results for commit 3c6d9a8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30‼️ +3K0.00⚠️ +0.140⚠️ +1680.00⚠️ +0.25
ESP32S20⚠️ +16760.00⚠️ +0.130⚠️ +1600.00⚠️ +0.39
ESP32C30‼️ +3K0.00⚠️ +0.150⚠️ +1680.00⚠️ +0.28
ESP32C6000.000.00000.000.00
ESP320⚠️ +18360.00⚠️ +0.090⚠️ +1600.00⚠️ +0.25
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
RainMaker/examples/RMakerCustom‼️ +2K⚠️ +168⚠️ +1312⚠️ +160‼️ +3K0--⚠️ +1484⚠️ +160
RainMaker/examples/RMakerCustomAirCooler‼️ +2K⚠️ +168⚠️ +1324⚠️ +160‼️ +3K0--⚠️ +1360⚠️ +160
RainMaker/examples/RMakerSonoffDualR3‼️ +2K⚠️ +168⚠️ +1328⚠️ +160‼️ +3K0--⚠️ +1356⚠️ +160
RainMaker/examples/RMakerSwitch‼️ +3K⚠️ +168⚠️ +1676⚠️ +160‼️ +3K⚠️ +168--⚠️ +1836⚠️ +160

@me-no-dev me-no-dev added the Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first label Jul 31, 2024
@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first labels Aug 1, 2024
@me-no-dev me-no-dev merged commit 2aa4828 into espressif:master Aug 1, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Rainmaker Issue is related to ESP Rainmaker. Status: Pending Merge Pull Request is ready to be merged Type: Example Issue is related to specific example.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants