Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ESP-NOW): Remove all peers on ESP_NOW.end() #10102

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR fixes ESP-NOW library, where on end() peers were not removed correctly.

Tests scenarios

Locally with ESP-NOW examples.

Related links

Related #10076

@P-R-O-C-H-Y P-R-O-C-H-Y added Area: Libraries Issue is related to Library support. Status: Review needed Issue or PR is awaiting review labels Aug 1, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.0.4 milestone Aug 1, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 7f98186

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +240.000.00000.000.00
ESP32S20⚠️ +240.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP320⚠️ +240.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ESP_NOW/examples/ESP_NOW_Broadcast_Master⚠️ +240⚠️ +2400000⚠️ +240
ESP_NOW/examples/ESP_NOW_Broadcast_Slave⚠️ +240⚠️ +2400000⚠️ +200
ESP_NOW/examples/ESP_NOW_Network⚠️ +240⚠️ +2400000⚠️ +200
ESP_NOW/examples/ESP_NOW_Serial⚠️ +240⚠️ +2400000⚠️ +240

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Test Results

 56 files   -  83   56 suites   - 83   4m 53s ⏱️ - 1h 37m 53s
 21 tests  -   9   21 ✅  -   9  0 💤 ±0  0 ❌ ±0 
135 runs   - 168  135 ✅  - 168  0 💤 ±0  0 ❌ ±0 

Results for commit 7f98186. ± Comparison against base commit 23b84e5.

This pull request removes 9 tests.
performance.coremark.test_coremark ‑ test_coremark
performance.fibonacci.test_fibonacci ‑ test_fibonacci
performance.psramspeed.test_psramspeed ‑ test_psramspeed
performance.ramspeed.test_ramspeed ‑ test_ramspeed
performance.superpi.test_superpi ‑ test_superpi
test_touch_errors
test_touch_interrtupt
test_touch_read
validation.periman.test_periman ‑ test_periman

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Aug 2, 2024
@me-no-dev me-no-dev merged commit 5aaa49e into espressif:master Aug 2, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Libraries Issue is related to Library support. Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

3 participants