-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving WebServer Example #10111
Improving WebServer Example #10111
Conversation
* Enable FAT and LittleFS filesystems as configured. * use new versions of RequestHandler::canHandle and RequestHandler::canUpload
👋 Hello mathertel, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Test Results 56 files - 83 56 suites - 83 5m 6s ⏱️ - 1h 38m 3s Results for commit b57b35f. ± Comparison against base commit 70786dc. This pull request removes 9 tests.
♻️ This comment has been updated with latest results. |
Please rename the PR to "Improving WebServer Example". The example is not broken. |
renaming done. The "old" handler canHandle(HTTPMethod , String) did not work for me when uploading files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathertel PTAL on my comments.
I have tested the updated example and it works great with both SPIFFS and FATFS. Thank you for your effort making this improvement :)
I'll change. Thanks for testing S2 and C6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides what has already been mentioned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixing WebServer example.
Description of Change
Tests scenarios
Arduino Nano ESP32 using arduino-esp version 3.0.4
Following the instructions in README