feat(LEDC): Adds the ability to set the clock source for the LEDC #10171
+63
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
👋 Hello konzen, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
konzen
changed the title
P-R-O-C-H-Y
reviewed
Aug 16, 2024
There was a problem hiding this comment.
Thanks @konzen for this nice improvement.
Just one thing, I would rather change the APIs to:
ledcSetClockSource and ledcGetClockSource
Also will you be able to update the documentation with those new functions?
(If not I can handle that :))
P-R-O-C-H-Y
added
the
Resolution: Awaiting response
|
@P-R-O-C-H-Y seems there is no response here. Could you please take over and finish the PR so we can merge it? |
Sure |
Test Results 56 files 56 suites 4m 51s ⏱️ Results for commit 5bed7e0. ♻️ This comment has been updated with latest results. |
Sorry for the delay in responding, I was traveling for work. |
|
As for updating the documentation, my English is "by Google Translate", I don't think it would be suitable. Could you handle that, please? |
me-no-dev
reviewed
Aug 28, 2024
cores/esp32/esp32-hal-ledc.c
Outdated
| @@ -47,6 +47,21 @@ ledc_periph_t ledc_handle = {0}; | |||
|
|
|||
| static bool fade_initialized = false; | |||
|
|
|||
| ledc_clk_cfg_t clock_source = LEDC_DEFAULT_CLK; | |||
me-no-dev
approved these changes
Aug 28, 2024
|
Thanks @konzen ! Looks good to me now |
VojtechBartoska
added
Status: In Progress
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
P-R-O-C-H-Y
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the LEDC clock source is fixed, which limits the possibilities, such as light sleep compatibility "ledcWriteClockSource(LEDC_USE_RC_FAST_CLK)".