-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webserver) Middleware with default middleware for cors, authc, curl-like logging #10186
base: master
Are you sure you want to change the base?
Conversation
👋 Hello mathieucarbou, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
0bc70ee
to
cf292b5
Compare
Test Results 56 files - 83 56 suites - 83 4m 56s ⏱️ - 1h 38m 21s Results for commit 9617be6. ± Comparison against base commit e70f4d3. This pull request removes 9 tests.
♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
@mathieucarbou Do you see the possibility to make this enhancement optional? |
I saw that and I was surprised by it... I don't feel to have written 2k of code... |
bc2dc4b
to
6607a91
Compare
Adding a ref to: #10221 (comment) |
…ors, authc, curl-like logging
31899b0
to
9617be6
Compare
This PR improves WebServer with the following additions:
As discussed in #10185, I tested the example thanks to a pio config.
Ideally it would be nice if @me-no-dev and @ayushsharma82 could review this PR, both were involved in these parts.