Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(push): Use FQBN from ci.json #10267

Merged
merged 1 commit into from
Aug 31, 2024
Merged

ci(push): Use FQBN from ci.json #10267

merged 1 commit into from
Aug 31, 2024

Conversation

lucasssvaz
Copy link
Collaborator

@lucasssvaz lucasssvaz commented Aug 30, 2024 •
edited
Loading

Description of Change

Make the compilation tests use ci.json FQBNs or use the defaults set in sketch_utils.sh

Related links

Required by #10265

@lucasssvaz lucasssvaz self-assigned this Aug 30, 2024
@lucasssvaz lucasssvaz changed the title ci(push): Use fqbn from ci.json ci(push): Use FQBN from ci.json Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 30, 2024 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9efb963

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3💚 -2104K‼️ +277K💚 -68.70‼️ +25.66💚 -25K‼️ +6K💚 -41.73‼️ +14.02
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3
ExampleFLASHRAM
ArduinoOTA/examples/BasicOTA‼️ +29K‼️ +3K
AsyncUDP/examples/AsyncUDPClient‼️ +48K‼️ +3K
AsyncUDP/examples/AsyncUDPMulticastServer‼️ +48K‼️ +3K
AsyncUDP/examples/AsyncUDPServer‼️ +48K‼️ +3K
BLE/examples/BLE5_extended_scan‼️ +212K💚 -8K
BLE/examples/BLE5_multi_advertising‼️ +213K💚 -8K
BLE/examples/BLE5_periodic_advertising‼️ +213K💚 -8K
BLE/examples/BLE5_periodic_sync‼️ +212K💚 -8K
BLE/examples/Beacon_Scanner‼️ +198K💚 -6K
BLE/examples/Client‼️ +198K💚 -6K
BLE/examples/EddystoneTLM_Beacon‼️ +196K💚 -6K
BLE/examples/EddystoneURL_Beacon‼️ +196K💚 -6K
BLE/examples/Notify‼️ +55K💚 -7K
BLE/examples/Scan‼️ +213K💚 -8K
DNSServer/examples/CaptivePortal‼️ +49K‼️ +3K
EEPROM/examples/eeprom_class‼️ +7K‼️ +2K
EEPROM/examples/eeprom_extra💚 -25K💚 -5K
EEPROM/examples/eeprom_write‼️ +8K‼️ +2K
ESP32/examples/AnalogOut/LEDCFade‼️ +8K‼️ +2K
ESP32/examples/AnalogOut/LEDCSingleChannel‼️ +7K‼️ +2K
ESP32/examples/AnalogOut/LEDCSoftwareFade‼️ +7K‼️ +2K
ESP32/examples/AnalogOut/SigmaDelta‼️ +7K‼️ +2K
ESP32/examples/AnalogOut/ledcFrequency‼️ +7K‼️ +2K
BLE/examples/Server‼️ +213K💚 -8K
BLE/examples/Server_multiconnect‼️ +214K💚 -8K
BLE/examples/UART‼️ +214K💚 -8K
BLE/examples/Write‼️ +198K💚 -6K
BLE/examples/iBeacon‼️ +198K💚 -6K
ESP32/examples/AnalogOut/ledcWrite_RGB💚 -24K💚 -5K
ESP32/examples/AnalogRead💚 -23K💚 -5K
ESP32/examples/AnalogReadContinuous💚 -26K💚 -5K
ESP32/examples/ArduinoStackSize💚 -25K💚 -5K
ESP32/examples/CI/CIBoardsTest💚 -28K💚 -5K
ESP32/examples/Camera/CameraWebServer💚 -2034K💚 -11K
ESP32/examples/ChipID/GetChipID💚 -27K💚 -5K
ESP32/examples/DeepSleep/ExternalWakeUp‼️ +5K‼️ +2K
ESP32/examples/DeepSleep/TimerWakeUp‼️ +5K‼️ +2K
ESP32/examples/DeepSleep/TouchWakeUp‼️ +5K⚠️ +1680
ESP32/examples/FreeRTOS/BasicMultiThreading💚 -17K⚠️ +1472
ESP32/examples/FreeRTOS/Mutex💚 -25K💚 -5K
ESP32/examples/FreeRTOS/Queue💚 -25K💚 -5K
BluetoothSerial/examples/DiscoverConnect--
BluetoothSerial/examples/GetLocalMAC--
BluetoothSerial/examples/SerialToSerialBT--
BluetoothSerial/examples/SerialToSerialBTM--
BluetoothSerial/examples/SerialToSerialBT_Legacy--
BluetoothSerial/examples/SerialToSerialBT_SSP--
BluetoothSerial/examples/bt_classic_device_discovery--
BluetoothSerial/examples/bt_remove_paired_devices--
ESP32/examples/FreeRTOS/Semaphore💚 -25K💚 -5K
ESP32/examples/GPIO/BlinkRGB💚 -28K💚 -5K
ESP32/examples/GPIO/FunctionalInterrupt💚 -25K💚 -6K
ESP32/examples/GPIO/FunctionalInterruptStruct💚 -25K💚 -6K
ESP32/examples/GPIO/GPIOInterrupt💚 -25K💚 -6K
ESP32/examples/MacAddress/GetMacAddress💚 -26K💚 -5K
ESP32/examples/RMT/Legacy_RMT_Driver_Compatible💚 -25K💚 -5K
ESP32/examples/RMT/RMTCallback💚 -27K💚 -5K
ESP32/examples/RMT/RMTLoopback💚 -26K💚 -5K
ESP32/examples/RMT/RMTReadXJT💚 -27K💚 -5K
ESP32/examples/RMT/RMTWrite_RGB_LED💚 -27K💚 -5K
ESP32/examples/RMT/RMT_CPUFreq_Test💚 -26K💚 -5K
ESP32/examples/RMT/RMT_EndOfTransmissionState💚 -26K💚 -5K
ESP32/examples/HWCDC_Events‼️ +16K💚 -5K
ESP32/examples/RMT/RMT_LED_Blink💚 -26K💚 -5K
ESP32/examples/ResetReason/ResetReason💚 -33K💚 -6K
ESP32/examples/ResetReason/ResetReason2💚 -25K💚 -5K
ESP32/examples/Serial/BaudRateDetect_Demo💚 -25K💚 -5K
ESP32/examples/Serial/OnReceiveError_BREAK_Demo💚 -25K💚 -5K
ESP32/examples/Serial/OnReceive_Demo💚 -25K💚 -5K
ESP32/examples/Serial/RS485_Echo_Demo💚 -25K💚 -5K
ESP32/examples/Serial/RxFIFOFull_Demo💚 -25K💚 -5K
ESP32/examples/Serial/RxTimeout_Demo💚 -25K💚 -5K
ESP32/examples/Serial/Serial_All_CPU_Freqs💚 -25K💚 -5K
ESP32/examples/Serial/Serial_STD_Func_OnReceive💚 -25K💚 -5K
ESP32/examples/Serial/onReceiveExample💚 -25K💚 -5K
ESP32/examples/TWAI/TWAIreceive💚 -25K💚 -5K
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code--
ESP32/examples/TWAI/TWAItransmit💚 -25K💚 -5K
ESP32/examples/Template/ExampleTemplate💚 -26K💚 -5K
ESP32/examples/Time/SimpleTime‼️ +48K‼️ +4K
ESP32/examples/Timer/RepeatTimer💚 -24K💚 -5K
ESP32/examples/Timer/WatchdogTimer💚 -24K💚 -5K
ESP32/examples/Touch/TouchButtonV2⚠️ +160
ESP32/examples/Touch/TouchInterrupt‼️ +7K⚠️ +1736
ESP32/examples/Touch/TouchRead‼️ +6K⚠️ +1736
ESP32/examples/Utilities/HEXBuilder💚 -25K💚 -5K
ESP32/examples/Utilities/MD5Builder💚 -25K💚 -5K
ESP32/examples/Utilities/SHA1Builder💚 -24K💚 -5K
ESP_I2S/examples/ES8388_loopback💚 -26K💚 -5K
ESP_I2S/examples/Simple_tone💚 -26K💚 -5K
ESP_I2S/examples/Record_to_WAV‼️ +3K‼️ +2K
ESP_NOW/examples/ESP_NOW_Broadcast_Master‼️ +48K‼️ +3K
ESP_NOW/examples/ESP_NOW_Broadcast_Slave‼️ +48K‼️ +3K
ESP_NOW/examples/ESP_NOW_Network‼️ +49K‼️ +3K
ESP_NOW/examples/ESP_NOW_Serial‼️ +48K‼️ +3K
ESPmDNS/examples/mDNS-SD_Extended‼️ +49K‼️ +3K
ESPmDNS/examples/mDNS_Web_Server‼️ +49K‼️ +3K
Ethernet/examples/ETH_W5500_Arduino_SPI💚 -13K💚 -5K
Ethernet/examples/ETH_W5500_IDF_SPI💚 -14K💚 -5K
Ethernet/examples/ETH_WIFI_BRIDGE‼️ +30K‼️ +3K
FFat/examples/FFat_Test💚 -21K💚 -5K
FFat/examples/FFat_time‼️ +49K‼️ +4K
HTTPClient/examples/Authorization‼️ +50K‼️ +5K
HTTPClient/examples/BasicHttpClient‼️ +50K‼️ +5K
ESP32/examples/Touch/TouchButton--
ESP_SR/examples/Basic⚠️ +160
HTTPClient/examples/BasicHttpsClient‼️ +50K‼️ +5K
HTTPClient/examples/HTTPClientEnterprise‼️ +50K‼️ +5K
HTTPClient/examples/ReuseConnection‼️ +50K‼️ +5K
HTTPClient/examples/StreamHttpClient‼️ +50K‼️ +5K
HTTPUpdate/examples/httpUpdate‼️ +29K‼️ +4K
HTTPUpdate/examples/httpUpdateSPIFFS‼️ +29K‼️ +4K
HTTPUpdate/examples/httpUpdateSecure‼️ +31K‼️ +4K
HTTPUpdateServer/examples/WebUpdater‼️ +29K‼️ +3K
Insights/examples/DiagnosticsSmokeTest‼️ +49K‼️ +3K
Insights/examples/MinimalDiagnostics‼️ +49K‼️ +3K
LittleFS/examples/LITTLEFS_test💚 -19K💚 -5K
LittleFS/examples/LITTLEFS_time‼️ +49K‼️ +4K
NetBIOS/examples/ESP_NBNST‼️ +48K‼️ +3K
NetworkClientSecure/examples/WiFiClientInsecure‼️ +50K‼️ +3K
NetworkClientSecure/examples/WiFiClientPSK‼️ +50K‼️ +3K
NetworkClientSecure/examples/WiFiClientSecure‼️ +50K‼️ +3K
NetworkClientSecure/examples/WiFiClientSecureEnterprise‼️ +50K‼️ +3K
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade‼️ +50K‼️ +3K
NetworkClientSecure/examples/WiFiClientShowPeerCredentials‼️ +50K‼️ +5K
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse‼️ +48K‼️ +3K
PPP/examples/PPP_Basic💚 -24K💚 -5K
PPP/examples/PPP_WIFI_BRIDGE‼️ +30K‼️ +3K
Preferences/examples/Prefs2Struct💚 -25K💚 -5K
Preferences/examples/StartCounter💚 -26K💚 -5K
RainMaker/examples/RMakerCustom‼️ +219K💚 -4K
RainMaker/examples/RMakerCustomAirCooler‼️ +211K💚 -4K
Ethernet/examples/ETH_LAN8720--
Ethernet/examples/ETH_TLK110--
RainMaker/examples/RMakerSonoffDualR3‼️ +219K💚 -4K
RainMaker/examples/RMakerSwitch‼️ +220K💚 -4K
SD/examples/SD_Test💚 -25K💚 -5K
SD/examples/SD_time‼️ +29K‼️ +3K
SPI/examples/SPI_Multiple_Buses💚 -15K⚠️ +1680
SPIFFS/examples/SPIFFS_Test💚 -20K💚 -5K
SPIFFS/examples/SPIFFS_time‼️ +49K‼️ +4K
TFLiteMicro/examples/hello_world💚 -23K💚 -5K
Ticker/examples/Blinker💚 -28K💚 -5K
Ticker/examples/TickerBasic💚 -28K💚 -5K
Ticker/examples/TickerParameter💚 -28K💚 -5K
USB/examples/CompositeDevice⚠️ +160
USB/examples/ConsumerControl⚠️ +160
OpenThread/examples/COAP/coap_lamp--
OpenThread/examples/COAP/coap_switch--
OpenThread/examples/SimpleCLI--
OpenThread/examples/SimpleNode--
OpenThread/examples/SimpleThreadNetwork/LeaderNode--
OpenThread/examples/SimpleThreadNetwork/RouterNode--
OpenThread/examples/ThreadScan--
OpenThread/examples/onReceive--
SD_MMC/examples/SD2USBMSC00
SD_MMC/examples/SDMMC_Test‼️ +8K‼️ +2K
SD_MMC/examples/SDMMC_time‼️ +47K‼️ +3K
SimpleBLE/examples/SimpleBleDevice‼️ +225K💚 -8K
USB/examples/CustomHIDDevice💚 -48K💚 -5K
USB/examples/FirmwareMSC00
USB/examples/Gamepad⚠️ +160
USB/examples/HIDVendor⚠️ +160
USB/examples/Keyboard/KeyboardLogout⚠️ +160
USB/examples/Keyboard/KeyboardMessage⚠️ +160
USB/examples/Keyboard/KeyboardReprogram⚠️ +160
USB/examples/Keyboard/KeyboardSerial⚠️ +160
USB/examples/KeyboardAndMouseControl⚠️ +160
USB/examples/MIDI/MidiController⚠️ +160
USB/examples/MIDI/MidiInterface00
USB/examples/MIDI/MidiMusicBox⚠️ +160
USB/examples/MIDI/ReceiveMidi⚠️ +160
USB/examples/Mouse/ButtonMouseControl💚 -48K💚 -5K
USB/examples/SystemControl💚 -48K💚 -5K
USB/examples/USBMSC⚠️ +160
USB/examples/USBSerial⚠️ +160
USB/examples/USBVendor⚠️ +160
Update/examples/AWS_S3_OTA_Update⚠️ +160
Update/examples/HTTPS_OTA_Update⚠️ +160
Update/examples/HTTP_Client_AES_OTA_Update‼️ +29K‼️ +4K
Update/examples/HTTP_Server_AES_OTA_Update‼️ +30K‼️ +3K
Update/examples/OTAWebUpdater‼️ +30K‼️ +3K
Update/examples/SD_Update💚 -27K💚 -5K
WebServer/examples/AdvancedWebServer‼️ +31K‼️ +3K
WebServer/examples/FSBrowser‼️ +49K‼️ +3K
WebServer/examples/Filters‼️ +31K‼️ +3K
WebServer/examples/HelloServer‼️ +31K‼️ +3K
WebServer/examples/HttpAdvancedAuth‼️ +29K‼️ +3K
WebServer/examples/HttpAuthCallback⚠️ +160
WebServer/examples/HttpAuthCallbackInline⚠️ +160
WebServer/examples/HttpBasicAuth⚠️ +160
WebServer/examples/HttpBasicAuthSHA1⚠️ +160
WebServer/examples/HttpBasicAuthSHA1orBearerToken‼️ +30K‼️ +3K
WebServer/examples/MultiHomedServers‼️ +31K‼️ +3K
WebServer/examples/PathArgServer‼️ +51K‼️ +4K
WebServer/examples/SDWebServer‼️ +31K‼️ +3K
WebServer/examples/SimpleAuthentification‼️ +49K‼️ +3K
WebServer/examples/UploadHugeFile‼️ +31K‼️ +4K
WebServer/examples/WebServer‼️ +50K‼️ +4K
WebServer/examples/WebUpdate‼️ +29K‼️ +3K
WiFi/examples/FTM/FTM_Initiator‼️ +47K‼️ +3K
WiFi/examples/FTM/FTM_Responder‼️ +48K‼️ +3K
WiFi/examples/SimpleWiFiServer⚠️ +160
WiFi/examples/WPS⚠️ +160
WiFi/examples/WiFiAccessPoint⚠️ +160
WiFi/examples/WiFiClient‼️ +49K‼️ +3K
WiFi/examples/WiFiClientBasic‼️ +49K‼️ +3K
WiFi/examples/WiFiClientConnect‼️ +47K‼️ +3K
WiFi/examples/WiFiClientEnterprise‼️ +50K‼️ +3K
WiFi/examples/WiFiClientEvents‼️ +48K‼️ +3K
WiFi/examples/WiFiClientStaticIP‼️ +49K‼️ +3K
WiFi/examples/WiFiBlueToothSwitch‼️ +99K‼️ +6K
WiFi/examples/WiFiExtender‼️ +48K‼️ +3K
WiFi/examples/WiFiIPv6‼️ +48K‼️ +3K
WiFi/examples/WiFiMulti‼️ +48K‼️ +3K
Wire/examples/WireMaster‼️ +7K‼️ +2K
Wire/examples/WireScan‼️ +7K‼️ +2K
WiFi/examples/WiFiMultiAdvanced‼️ +50K‼️ +5K
WiFi/examples/WiFiScan⚠️ +160
WiFi/examples/WiFiScanAsync⚠️ +160
WiFi/examples/WiFiScanDualAntenna‼️ +48K‼️ +3K
WiFi/examples/WiFiScanTime‼️ +48K‼️ +3K
WiFi/examples/WiFiSmartConfig‼️ +50K‼️ +3K
WiFi/examples/WiFiTelnetToSerial‼️ +49K‼️ +3K
WiFi/examples/WiFiUDPClient‼️ +48K‼️ +3K
WiFiProv/examples/WiFiProv‼️ +230K💚 -5K
Wire/examples/WireSlave‼️ +7K‼️ +2K

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Aug 30, 2024
@me-no-dev me-no-dev merged commit 4c1095b into espressif:master Aug 31, 2024
48 checks passed
@lucasssvaz lucasssvaz deleted the ci/compilation_fqbn branch September 16, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@me-no-dev me-no-dev me-no-dev approved these changes

Assignees

@lucasssvaz lucasssvaz

Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasssvaz @me-no-dev @P-R-O-C-H-Y