Added Sparkfun ESP32-S3 Thing Plus board #10382

Vigeant · 2024-09-26T18:49:44Z

Description of Change

Added support for Sparkfun ESP32-S3 Thing Plus based on sparkfun's example:

https://docs.sparkfun.com/SparkFun_Thing_Plus_ESP32-S3/arduino_example/#thing-plus-esp32-s3-github-repository

This guide uses the ESP32-S3 DEV Board and then redefines pins to adapt. I used the ESP32-S3 DEV Board as a base and made the changes in the boards.txt and the pins_arduino.h file to match the guide'options and the board's pin layout.

Tests scenarios

I have tested my Pull Request with sparkfun's examples on Arduino-esp32 core v3.1.0 with ESP32 and ESP32-S3 Board.

Related links

https://github.com/sparkfun/SparkFun_Thing_Plus_ESP32-S3
https://docs.sparkfun.com/SparkFun_Thing_Plus_ESP32-S3/arduino_example/#thing-plus-esp32-s3-github-repository

added board Sparkfun ESP32-S3 Thing Plus

rebasing to latest head

CLAassistant · 2024-09-26T18:50:13Z

All committers have signed the CLA.

github-actions · 2024-09-26T18:50:21Z

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message `"Create pins_arduino.h"`: summary looks empty type/action looks empty the commit message `"Update pins_arduino.h"`: summary looks empty type/action looks empty the commit message `"added board Sparkfun ESP32-S3 Thing Plus"`: summary looks empty type/action looks empty the commit message `"added sparkfun esp32-s3 thing plus"`: summary looks empty type/action looks empty the commit message `"readded last line of hashes in boards.txt"`: summary looks empty type/action looks empty the commit message `"removed unapplicable flash configurations the sparkfun esp32-s3 thing plus"`: summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: `<type/action>(<scope/component>): <summary>`, for example `fix(esp32): Fixed startup timeout issue` allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️	Please consider squashing your 10 commits (simplifying branch history).

👋 Hello Vigeant, we appreciate your contribution to this project!

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 60838eb

re-added SS pin to pass test

P-R-O-C-H-Y

@Vigeant PTAL

boards.txt

P-R-O-C-H-Y · 2024-09-27T06:44:48Z

boards.txt

+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.rainmaker_8MB=RainMaker 8MB
+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.rainmaker_8MB.build.partitions=rainmaker_8MB
+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.rainmaker_8MB.upload.maximum_size=4116480
+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.app5M_fat24M_32MB=32M Flash (4.8MB APP/22MB FATFS)
+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.app5M_fat24M_32MB.build.partitions=large_fat_32MB
+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.app5M_fat24M_32MB.upload.maximum_size=4718592
+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.app5M_little24M_32MB=32M Flash (4.8MB APP/22MB LittleFS)
+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.app5M_little24M_32MB.build.partitions=large_littlefs_32MB
+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.app5M_little24M_32MB.upload.maximum_size=4718592
+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.esp_sr_16=ESP SR 16M (3MB APP/7MB SPIFFS/2.9MB MODEL)
+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.esp_sr_16.upload.maximum_size=3145728
+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.esp_sr_16.upload.extra_flags=0xD10000 {build.path}/srmodels.bin
+sparkfun_esp32s3_thing_plus.menu.PartitionScheme.esp_sr_16.build.partitions=esp_sr_16


Same here.

Suggested change

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.rainmaker_8MB=RainMaker 8MB

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.rainmaker_8MB.build.partitions=rainmaker_8MB

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.rainmaker_8MB.upload.maximum_size=4116480

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.app5M_fat24M_32MB=32M Flash (4.8MB APP/22MB FATFS)

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.app5M_fat24M_32MB.build.partitions=large_fat_32MB

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.app5M_fat24M_32MB.upload.maximum_size=4718592

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.app5M_little24M_32MB=32M Flash (4.8MB APP/22MB LittleFS)

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.app5M_little24M_32MB.build.partitions=large_littlefs_32MB

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.app5M_little24M_32MB.upload.maximum_size=4718592

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.esp_sr_16=ESP SR 16M (3MB APP/7MB SPIFFS/2.9MB MODEL)

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.esp_sr_16.upload.maximum_size=3145728

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.esp_sr_16.upload.extra_flags=0xD10000 {build.path}/srmodels.bin

sparkfun_esp32s3_thing_plus.menu.PartitionScheme.esp_sr_16.build.partitions=esp_sr_16

made changes in last commit. Let me know if I should have created a branch before doing the pull request.

No it's fine like it is :) we will merge soon. Thanks for the fixes.

But yeah, maybe next time create a branch with proper naming for the derived "changes" ;)

… plus

removed commented code

* Create pins_arduino.h * added board Sparkfun ESP32-S3 Thing Plus added board Sparkfun ESP32-S3 Thing Plus * readded last line of hashes in boards.txt * Update pins_arduino.h re-added SS pin to pass test * removed unapplicable flash configurations the sparkfun esp32-s3 thing plus * added sparkfun esp32-s3 thing plus removed commented code * ci(pre-commit): Apply automatic fixes --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

Vigeant · 2024-10-09T00:23:05Z

hey @P-R-O-C-H-Y how are you setup to use the latest master for your arduino IDE or PlatformIO setup?

Vigeant added 5 commits September 19, 2024 22:31

Create pins_arduino.h

494d600

added board Sparkfun ESP32-S3 Thing Plus

7e2ec39

added board Sparkfun ESP32-S3 Thing Plus

Merge pull request #2 from espressif/master

5d102d1

rebasing to latest head

readded last line of hashes in boards.txt

25d8ae4

Merge branch 'master' of https://github.com/Vigeant/arduino-esp32

19fb450

me-no-dev requested a review from P-R-O-C-H-Y September 26, 2024 18:51

Update pins_arduino.h

fbb740d

re-added SS pin to pass test

P-R-O-C-H-Y requested changes Sep 27, 2024

View reviewed changes

P-R-O-C-H-Y added the Type: 3rd party Boards label Sep 27, 2024

Vigeant added 3 commits September 27, 2024 10:32

removed unapplicable flash configurations the sparkfun esp32-s3 thing…

0fc52be

… plus

Merge branch 'master' of https://github.com/Vigeant/arduino-esp32

c1eab2e

added sparkfun esp32-s3 thing plus

e035231

removed commented code

Vigeant force-pushed the master branch from a1ec01e to e035231 Compare September 27, 2024 14:59

P-R-O-C-H-Y approved these changes Sep 30, 2024

View reviewed changes

P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Sep 30, 2024

ci(pre-commit): Apply automatic fixes

60838eb

me-no-dev merged commit 1f1de27 into espressif:master Sep 30, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Sparkfun ESP32-S3 Thing Plus board #10382

Added Sparkfun ESP32-S3 Thing Plus board #10382

Vigeant commented Sep 26, 2024

CLAassistant commented Sep 26, 2024 •

edited

Loading

github-actions bot commented Sep 26, 2024 •

edited

Loading

P-R-O-C-H-Y left a comment

P-R-O-C-H-Y Sep 27, 2024

Vigeant Sep 27, 2024

P-R-O-C-H-Y Sep 30, 2024

P-R-O-C-H-Y Sep 30, 2024

Vigeant commented Oct 9, 2024

Added Sparkfun ESP32-S3 Thing Plus board #10382

Added Sparkfun ESP32-S3 Thing Plus board #10382

Conversation

Vigeant commented Sep 26, 2024

Description of Change

Tests scenarios

Related links

CLAassistant commented Sep 26, 2024 • edited Loading

github-actions bot commented Sep 26, 2024 • edited Loading

P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

P-R-O-C-H-Y Sep 27, 2024

Choose a reason for hiding this comment

Vigeant Sep 27, 2024

Choose a reason for hiding this comment

P-R-O-C-H-Y Sep 30, 2024

Choose a reason for hiding this comment

P-R-O-C-H-Y Sep 30, 2024

Choose a reason for hiding this comment

Vigeant commented Oct 9, 2024

CLAassistant commented Sep 26, 2024 •

edited

Loading

github-actions bot commented Sep 26, 2024 •

edited

Loading