feat(Variants): Add Arduino libraries for Lora 4G Module and Node Wifi o… #10402

Bharat-Pi · 2024-10-02T13:32:00Z

…f BharatPi boards variant.

Description of Change

This Pull Request add support to three new hardware on the market using ESP32 modules, Bharat Pi Node Wifi , Bharat Pi A7672s 4G and Bharat Pi LoRa modules. Links to the hardware is provided below

Bharat Pi Node Wifi
https://bharatpi.net/product/bharat-pi-node-wifi/

Bharat Pi A7672s 4G Board
https://bharatpi.net/product/bharat-pi-4g-lte-module-with-esp32-simcom-a7672-with-gps/

Bharat Pi LoRa boards with Indian Frequency
https://bharatpi.net/product/bharat-pi-lora-module-with-esp32-lora868mhz-transreceiver-with-esp32-arduino-compatible/

These boards are used by Students, Tinkerers across 100s of different colleges and universities and we are connected with the Espressif to launch these boards.

Tests scenarios

We have tested these changes on a Bharat Pi boards using the Arduino IDE and the ESP32 core with 4MB, 8MB and 16MB flash versions of ESP32.
We have verified that the defined pins correspond to the correct hardware pins on the board.
We tested the samples codes and libraries of our code and example codes.
You can see our test codes in this page
https://github.com/Bharat-Pi/iot-projects

Related links

This is a support package for new variant
https://github.com/Bharat-Pi/iot-projects
https://bharatpi.net/product/bharat-pi-node-wifi/
https://bharatpi.net/product/bharat-pi-4g-lte-module-with-esp32-simcom-a7672-with-gps/
https://bharatpi.net/product/bharat-pi-lora-module-with-esp32-lora868mhz-transreceiver-with-esp32-arduino-compatible/

github-actions · 2024-10-02T13:33:26Z

	Warnings
⚠️	Please consider squashing your 9 commits (simplifying branch history).

👋 Hello Bharat-Pi, we appreciate your contribution to this project!

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 903f120

variants/BharatPi-Node-Wifi/pins_arduino.h

variants/BharatPi-A7672S-4G/pins_arduino.h

P-R-O-C-H-Y

@Bharat-Pi PTAL on my comments.
As you are using 4MB Flash chip, please remove other options and unusable partitions for all the boards. Thanks, otherwise its looking good.

boards.txt

P-R-O-C-H-Y · 2024-10-04T09:16:13Z

boards.txt

+BharatPi-Node-Wifi.menu.FlashSize.8M=8MB (64Mb)
+BharatPi-Node-Wifi.menu.FlashSize.8M.build.flash_size=8MB
+BharatPi-Node-Wifi.menu.FlashSize.8M.build.partitions=default_8MB
+BharatPi-Node-Wifi.menu.FlashSize.16M=16MB (128Mb)
+BharatPi-Node-Wifi.menu.FlashSize.16M.build.flash_size=16MB


You can remove those as the board is made with 4MB flash chip

Suggested change

BharatPi-Node-Wifi.menu.FlashSize.8M=8MB (64Mb)

BharatPi-Node-Wifi.menu.FlashSize.8M.build.flash_size=8MB

BharatPi-Node-Wifi.menu.FlashSize.8M.build.partitions=default_8MB

BharatPi-Node-Wifi.menu.FlashSize.16M=16MB (128Mb)

BharatPi-Node-Wifi.menu.FlashSize.16M.build.flash_size=16MB

P-R-O-C-H-Y · 2024-10-04T09:16:44Z

boards.txt

+BharatPi-Node-Wifi.build.loop_core=
+BharatPi-Node-Wifi.build.event_core=
+
+BharatPi-Node-Wifi.menu.PartitionScheme.default=Default 4MB with spiffs (1.2MB APP/1.5MB SPIFFS)


Also go through all partition schemes and remove those that are not for 4MB Flash size.

boards.txt

P-R-O-C-H-Y · 2024-10-04T09:18:47Z

boards.txt

+BharatPi-A7672S-4G.menu.FlashSize.8M=8MB (64Mb)
+BharatPi-A7672S-4G.menu.FlashSize.8M.build.flash_size=8MB
+BharatPi-A7672S-4G.menu.FlashSize.8M.build.partitions=default_8MB
+BharatPi-A7672S-4G.menu.FlashSize.16M=16MB (128Mb)
+BharatPi-A7672S-4G.menu.FlashSize.16M.build.flash_size=16MB


Same here:

Suggested change

BharatPi-A7672S-4G.menu.FlashSize.8M=8MB (64Mb)

BharatPi-A7672S-4G.menu.FlashSize.8M.build.flash_size=8MB

BharatPi-A7672S-4G.menu.FlashSize.8M.build.partitions=default_8MB

BharatPi-A7672S-4G.menu.FlashSize.16M=16MB (128Mb)

BharatPi-A7672S-4G.menu.FlashSize.16M.build.flash_size=16MB

boards.txt

P-R-O-C-H-Y · 2024-10-04T09:20:04Z

boards.txt

+BharatPi-LoRa.menu.FlashSize.8M=8MB (64Mb)
+BharatPi-LoRa.menu.FlashSize.8M.build.flash_size=8MB
+BharatPi-LoRa.menu.FlashSize.8M.build.partitions=default_8MB
+BharatPi-LoRa.menu.FlashSize.16M=16MB (128Mb)
+BharatPi-LoRa.menu.FlashSize.16M.build.flash_size=16MB


If it also uses 4MB flash please remove those options and remove the unusable partitions.

VojtechBartoska · 2024-10-07T07:11:02Z

Hello @Bharat-Pi, please take a look on proposed changes by @P-R-O-C-H-Y.

Bharat-Pi · 2024-10-07T08:06:40Z

Hello @Bharat-Pi, please take a look on proposed changes by @P-R-O-C-H-Y.

Somehow my comments are not shown
Here is the comments I mentioned

Though the board picture you see in the website has 4MB flash, We have boards with 8MB and 16MB Flash versions, which are used by ones who wants more flash memory and trying edge ai workloads. I have also mentioned the same in the description.

This is same for all three boards, Hence we would need partition and flash size of 8MB and 16MB also.

It is showing as pending for me not sure why . I have resolved other comments regarding board name , please check and approve the PR

P-R-O-C-H-Y

@Bharat-Pi ----

boards.txt

P-R-O-C-H-Y · 2024-10-07T08:10:43Z

@Bharat-Pi Thanks for the info, one small nitpick about the build.board name. Else it's looking good. Once fixed and CI passes we can merge :)

Bharat-Pi · 2024-10-07T08:26:06Z

@Bharat-Pi Thanks for the info, one small nitpick about the build.board name. Else it's looking good. Once fixed and CI passes we can merge :)

Fixed and pushed the changes, Thanks for the quick support. Hope it gets merged today

Bharat-Pi force-pushed the master branch from 15a7244 to e37790a Compare October 2, 2024 13:43

feat(esp32): Added support for BharatPi 4G, LoRa & NodeWifi Boards

a21cae5

Bharat-Pi force-pushed the master branch from e37790a to a21cae5 Compare October 2, 2024 13:50

Bharat-Pi changed the title ~~feat(esp32): Add Arduino libraries for Lora 4G Module and Node Wifi o…~~ feat(Variants): Add Arduino libraries for Lora 4G Module and Node Wifi o… Oct 2, 2024

Merge branch 'master' into master

034d303

me-no-dev requested a review from P-R-O-C-H-Y October 2, 2024 14:05

P-R-O-C-H-Y requested changes Oct 2, 2024

View reviewed changes

variants/BharatPi-Node-Wifi/pins_arduino.h Outdated Show resolved Hide resolved

variants/BharatPi-A7672S-4G/pins_arduino.h Show resolved Hide resolved

P-R-O-C-H-Y added the Type: 3rd party Boards label Oct 2, 2024

fix(variant): Fixed review comments for SPI and I2C Pins

a55abe0

Bharat-Pi force-pushed the master branch from 7c185d7 to a55abe0 Compare October 2, 2024 16:23

fix(variant): Fixed review comments and Lora build fix

805324a

Bharat-Pi requested a review from P-R-O-C-H-Y October 2, 2024 16:24

Merge branch 'master' into master

bca1f9b

P-R-O-C-H-Y requested changes Oct 4, 2024

View reviewed changes

Bharat-Pi added 2 commits October 5, 2024 22:19

Merge branch 'master' into master

e647e60

fix(variant): Fixed review comments for board name

7464749

Bharat-Pi requested a review from P-R-O-C-H-Y October 5, 2024 17:17

VojtechBartoska added the Resolution: Awaiting response Waiting for response of author label Oct 7, 2024

P-R-O-C-H-Y requested changes Oct 7, 2024

View reviewed changes

boards.txt Show resolved Hide resolved

boards.txt Show resolved Hide resolved

P-R-O-C-H-Y reviewed Oct 7, 2024

View reviewed changes

boards.txt Show resolved Hide resolved

fix(review): Fixed review comment for CI

557dab8

P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Oct 7, 2024

P-R-O-C-H-Y approved these changes Oct 7, 2024

View reviewed changes

ci(pre-commit): Apply automatic fixes

903f120

me-no-dev merged commit 630377f into espressif:master Oct 7, 2024
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Variants): Add Arduino libraries for Lora 4G Module and Node Wifi o… #10402

feat(Variants): Add Arduino libraries for Lora 4G Module and Node Wifi o… #10402

Bharat-Pi commented Oct 2, 2024

github-actions bot commented Oct 2, 2024 •

edited

Loading

P-R-O-C-H-Y left a comment

P-R-O-C-H-Y Oct 4, 2024

P-R-O-C-H-Y Oct 4, 2024

P-R-O-C-H-Y Oct 4, 2024

P-R-O-C-H-Y Oct 4, 2024

VojtechBartoska commented Oct 7, 2024

Bharat-Pi commented Oct 7, 2024

P-R-O-C-H-Y left a comment •

edited

Loading

P-R-O-C-H-Y commented Oct 7, 2024

Bharat-Pi commented Oct 7, 2024

feat(Variants): Add Arduino libraries for Lora 4G Module and Node Wifi o… #10402

feat(Variants): Add Arduino libraries for Lora 4G Module and Node Wifi o… #10402

Conversation

Bharat-Pi commented Oct 2, 2024

Description of Change

Tests scenarios

Related links

github-actions bot commented Oct 2, 2024 • edited Loading

P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

P-R-O-C-H-Y Oct 4, 2024

Choose a reason for hiding this comment

P-R-O-C-H-Y Oct 4, 2024

Choose a reason for hiding this comment

P-R-O-C-H-Y Oct 4, 2024

Choose a reason for hiding this comment

P-R-O-C-H-Y Oct 4, 2024

Choose a reason for hiding this comment

VojtechBartoska commented Oct 7, 2024

Bharat-Pi commented Oct 7, 2024

P-R-O-C-H-Y left a comment • edited Loading

Choose a reason for hiding this comment

P-R-O-C-H-Y commented Oct 7, 2024

Bharat-Pi commented Oct 7, 2024

github-actions bot commented Oct 2, 2024 •

edited

Loading

P-R-O-C-H-Y left a comment •

edited

Loading