Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spiram): Fix OPI PSRAM init #10406

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix(spiram): Fix OPI PSRAM init #10406

merged 1 commit into from
Oct 2, 2024

Conversation

me-no-dev
Copy link
Member

OPI PSRAM was not registered as started and was preventing it from working.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix(spiram): Fix OPI PSRAM init":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello me-no-dev, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2edc8e5

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

Test Results

 41 files   41 suites   3m 13s ⏱️
 19 tests  19 ✅ 0 💤 0 ❌
120 runs  120 ✅ 0 💤 0 ❌

Results for commit 2edc8e5.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +720.00⚠️ +0.02000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ArduinoOTA/examples/BasicOTA⚠️ +520000000--00
AsyncUDP/examples/AsyncUDPClient⚠️ +520000000--00
AsyncUDP/examples/AsyncUDPMulticastServer⚠️ +560000000--00
AsyncUDP/examples/AsyncUDPServer⚠️ +320000000--00
BLE/examples/BLE5_extended_scan⚠️ +560--000000--
BLE/examples/BLE5_multi_advertising⚠️ +520--000000--
BLE/examples/BLE5_periodic_advertising⚠️ +480--000000--
BLE/examples/BLE5_periodic_sync⚠️ +520--000000--
BLE/examples/Beacon_Scanner⚠️ +520--00000000
BLE/examples/Client⚠️ +520--00000000
BLE/examples/EddystoneTLM_Beacon⚠️ +520--00000000
BLE/examples/EddystoneURL_Beacon⚠️ +400--00000000
BLE/examples/Notify⚠️ +520--00000000
BLE/examples/Scan⚠️ +520--00000000
BLE/examples/Server⚠️ +520--00000000
BLE/examples/Server_multiconnect⚠️ +520--00000000
BLE/examples/UART⚠️ +720--00000000
BLE/examples/Write⚠️ +520--00000000
BLE/examples/iBeacon⚠️ +520--00000000
DNSServer/examples/CaptivePortal⚠️ +560000000--00
EEPROM/examples/eeprom_class⚠️ +5200000000000
EEPROM/examples/eeprom_extra⚠️ +5200000000000
EEPROM/examples/eeprom_write⚠️ +5200000000000
ESP32/examples/AnalogOut/LEDCFade⚠️ +5200000000000
ESP32/examples/AnalogOut/LEDCSingleChannel⚠️ +5200000000000
ESP32/examples/AnalogOut/LEDCSoftwareFade⚠️ +5200000000000
ESP32/examples/AnalogOut/SigmaDelta⚠️ +5200000000000
ESP32/examples/AnalogOut/ledcFrequency⚠️ +5200000000000
ESP32/examples/AnalogOut/ledcWrite_RGB⚠️ +5200000000000
ESP32/examples/AnalogRead⚠️ +5200000000000
ESP32/examples/AnalogReadContinuous⚠️ +5200000000000
ESP32/examples/ArduinoStackSize⚠️ +5200000000000
ESP32/examples/CI/CIBoardsTest⚠️ +5200000000000
ESP32/examples/Camera/CameraWebServer⚠️ +52000------00
ESP32/examples/ChipID/GetChipID⚠️ +5200000000000
ESP32/examples/DeepSleep/ExternalWakeUp⚠️ +52000------00
ESP32/examples/DeepSleep/TimerWakeUp⚠️ +520000000--00
ESP32/examples/DeepSleep/TouchWakeUp⚠️ +52000------00
ESP32/examples/FreeRTOS/BasicMultiThreading⚠️ +5200000000000
ESP32/examples/FreeRTOS/Mutex⚠️ +5200000000000
ESP32/examples/FreeRTOS/Queue⚠️ +5200000000000
ESP32/examples/FreeRTOS/Semaphore⚠️ +5200000000000
ESP32/examples/GPIO/BlinkRGB⚠️ +5200000000000
ESP32/examples/GPIO/FunctionalInterrupt⚠️ +5200000000000
ESP32/examples/GPIO/FunctionalInterruptStruct⚠️ +5200000000000
ESP32/examples/GPIO/GPIOInterrupt⚠️ +5200000000000
ESP32/examples/HWCDC_Events00--000000--
ESP32/examples/MacAddress/GetMacAddress⚠️ +5200000000000
ESP32/examples/RMT/Legacy_RMT_Driver_Compatible⚠️ +5200000000000
ESP32/examples/RMT/RMTCallback⚠️ +5200000000000
ESP32/examples/RMT/RMTLoopback⚠️ +5200000000000
ESP32/examples/RMT/RMTReadXJT⚠️ +5200000000000
ESP32/examples/RMT/RMTWrite_RGB_LED⚠️ +5200000000000
ESP32/examples/RMT/RMT_CPUFreq_Test⚠️ +5200000000000
ESP32/examples/RMT/RMT_EndOfTransmissionState⚠️ +5200000000000
ESP32/examples/RMT/RMT_LED_Blink⚠️ +5200000000000
ESP32/examples/ResetReason/ResetReason⚠️ +5200000000000
ESP32/examples/ResetReason/ResetReason2⚠️ +5200000000000
ESP32/examples/Serial/BaudRateDetect_Demo⚠️ +5200000000000
ESP32/examples/Serial/OnReceiveError_BREAK_Demo⚠️ +5200000000000
ESP32/examples/Serial/OnReceive_Demo⚠️ +5200000000000
ESP32/examples/Serial/RS485_Echo_Demo⚠️ +5200000000000
ESP32/examples/Serial/RxFIFOFull_Demo⚠️ +5200000000000
ESP32/examples/Serial/RxTimeout_Demo⚠️ +5200000000000
ESP32/examples/Serial/Serial_All_CPU_Freqs⚠️ +5200000000000
ESP32/examples/Serial/Serial_STD_Func_OnReceive⚠️ +5200000000000
ESP32/examples/Serial/onReceiveExample⚠️ +5200000000000
ESP32/examples/TWAI/TWAIreceive⚠️ +5200000000000
ESP32/examples/TWAI/TWAItransmit⚠️ +5200000000000
ESP32/examples/Template/ExampleTemplate⚠️ +5200000000000
ESP32/examples/Time/SimpleTime⚠️ +520000000--00
ESP32/examples/Timer/RepeatTimer⚠️ +5200000000000
ESP32/examples/Timer/WatchdogTimer⚠️ +5200000000000
ESP32/examples/Touch/TouchButtonV2⚠️ +52000--------
ESP32/examples/Touch/TouchInterrupt⚠️ +52000------00
ESP32/examples/Touch/TouchRead⚠️ +52000------00
ESP32/examples/Utilities/HEXBuilder⚠️ +5200000000000
ESP32/examples/Utilities/MD5Builder⚠️ +5200000000000
ESP32/examples/Utilities/SHA1Builder⚠️ +5200000000000
ESP_I2S/examples/ES8388_loopback⚠️ +5200000000000
ESP_I2S/examples/Record_to_WAV⚠️ +520--------00
ESP_I2S/examples/Simple_tone⚠️ +5200000000000
ESP_NOW/examples/ESP_NOW_Broadcast_Master⚠️ +520000000--00
ESP_NOW/examples/ESP_NOW_Broadcast_Slave⚠️ +520000000--00
ESP_NOW/examples/ESP_NOW_Network⚠️ +520000000--00
ESP_NOW/examples/ESP_NOW_Serial⚠️ +520000000--00
ESP_SR/examples/Basic00----------
ESPmDNS/examples/mDNS-SD_Extended⚠️ +560000000--00
ESPmDNS/examples/mDNS_Web_Server⚠️ +560000000--00
Ethernet/examples/ETH_W5500_Arduino_SPI⚠️ +5600000000000
Ethernet/examples/ETH_W5500_IDF_SPI⚠️ +4800000000000
Ethernet/examples/ETH_WIFI_BRIDGE⚠️ +520000000--00
FFat/examples/FFat_Test⚠️ +5200000000000
FFat/examples/FFat_time⚠️ +520000000--00
HTTPClient/examples/Authorization⚠️ +520000000--00
HTTPClient/examples/BasicHttpClient⚠️ +520000000--00
HTTPClient/examples/BasicHttpsClient⚠️ +520000000--00
HTTPClient/examples/HTTPClientEnterprise⚠️ +520000000--00
HTTPClient/examples/ReuseConnection⚠️ +520000000--00
HTTPClient/examples/StreamHttpClient⚠️ +520000000--00
HTTPUpdate/examples/httpUpdate⚠️ +520000000--00
HTTPUpdate/examples/httpUpdateSPIFFS⚠️ +520000000--00
HTTPUpdate/examples/httpUpdateSecure⚠️ +600000000--00
HTTPUpdateServer/examples/WebUpdater⚠️ +520000000--00
Insights/examples/DiagnosticsSmokeTest⚠️ +520000000--00
Insights/examples/MinimalDiagnostics⚠️ +520000000--00
LittleFS/examples/LITTLEFS_test⚠️ +5200000000000
LittleFS/examples/LITTLEFS_time⚠️ +520000000--00
NetBIOS/examples/ESP_NBNST⚠️ +560000000--00
NetworkClientSecure/examples/WiFiClientInsecure⚠️ +520000000--00
NetworkClientSecure/examples/WiFiClientPSK⚠️ +480000000--00
NetworkClientSecure/examples/WiFiClientSecure⚠️ +520000000--00
NetworkClientSecure/examples/WiFiClientSecureEnterprise⚠️ +520000000--00
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade⚠️ +520000000--00
NetworkClientSecure/examples/WiFiClientShowPeerCredentials⚠️ +520000000--00
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse⚠️ +520000000--00
PPP/examples/PPP_Basic⚠️ +5200000000000
PPP/examples/PPP_WIFI_BRIDGE⚠️ +520000000--00
Preferences/examples/Prefs2Struct⚠️ +5200000000000
Preferences/examples/StartCounter⚠️ +5200000000000
RainMaker/examples/RMakerCustom⚠️ +520000000--00
RainMaker/examples/RMakerCustomAirCooler⚠️ +560000000--00
RainMaker/examples/RMakerSonoffDualR3⚠️ +520000000--00
RainMaker/examples/RMakerSwitch⚠️ +560000000--00
SD/examples/SD_Test⚠️ +5200000000000
SD/examples/SD_time⚠️ +520000000--00
SD_MMC/examples/SD2USBMSC⚠️ +520----------
SD_MMC/examples/SDMMC_Test⚠️ +520--------00
SD_MMC/examples/SDMMC_time⚠️ +520--------00
SPI/examples/SPI_Multiple_Buses⚠️ +5200000000000
SPIFFS/examples/SPIFFS_Test⚠️ +5200000000000
SPIFFS/examples/SPIFFS_time⚠️ +520000000--00
SimpleBLE/examples/SimpleBleDevice⚠️ +600--00000000
TFLiteMicro/examples/hello_world⚠️ +5200000000000
Ticker/examples/Blinker⚠️ +5200000000000
Ticker/examples/TickerBasic⚠️ +5200000000000
Ticker/examples/TickerParameter⚠️ +5200000000000
USB/examples/CompositeDevice⚠️ +52000--------
USB/examples/ConsumerControl⚠️ +52000--------
USB/examples/CustomHIDDevice⚠️ +52000--------
USB/examples/FirmwareMSC⚠️ +52000--------
USB/examples/Gamepad⚠️ +52000--------
USB/examples/HIDVendor⚠️ +52000--------
USB/examples/Keyboard/KeyboardLogout⚠️ +52000--------
USB/examples/Keyboard/KeyboardMessage⚠️ +52000--------
USB/examples/Keyboard/KeyboardReprogram⚠️ +52000--------
USB/examples/Keyboard/KeyboardSerial⚠️ +52000--------
USB/examples/KeyboardAndMouseControl⚠️ +52000--------
USB/examples/MIDI/MidiController⚠️ +52000--------
USB/examples/MIDI/MidiInterface⚠️ +52000--------
USB/examples/MIDI/MidiMusicBox⚠️ +52000--------
USB/examples/MIDI/ReceiveMidi⚠️ +52000--------
USB/examples/Mouse/ButtonMouseControl⚠️ +52000--------
USB/examples/SystemControl⚠️ +52000--------
USB/examples/USBMSC⚠️ +52000--------
USB/examples/USBSerial⚠️ +52000--------
USB/examples/USBVendor⚠️ +52000--------
Update/examples/AWS_S3_OTA_Update⚠️ +520000000--00
Update/examples/HTTPS_OTA_Update⚠️ +560000000--00
Update/examples/HTTP_Client_AES_OTA_Update⚠️ +520000000--00
Update/examples/HTTP_Server_AES_OTA_Update⚠️ +520000000--00
Update/examples/OTAWebUpdater⚠️ +520000000--00
Update/examples/SD_Update⚠️ +5200000000000
WebServer/examples/AdvancedWebServer⚠️ +560000000--00
WebServer/examples/FSBrowser⚠️ +520000000--00
WebServer/examples/Filters⚠️ +520000000--00
WebServer/examples/HelloServer⚠️ +520000000--00
WebServer/examples/HttpAdvancedAuth⚠️ +520000000--00
WebServer/examples/HttpAuthCallback⚠️ +520000000--00
WebServer/examples/HttpAuthCallbackInline⚠️ +520000000--00
WebServer/examples/HttpBasicAuth⚠️ +440000000--00
WebServer/examples/HttpBasicAuthSHA1⚠️ +520000000--00
WebServer/examples/HttpBasicAuthSHA1orBearerToken⚠️ +520000000--00
WebServer/examples/MultiHomedServers⚠️ +520000000--00
WebServer/examples/PathArgServer⚠️ +520000000--00
WebServer/examples/SDWebServer⚠️ +560000000--00
WebServer/examples/SimpleAuthentification⚠️ +520000000--00
WebServer/examples/UploadHugeFile⚠️ +520000000--00
WebServer/examples/WebServer⚠️ +520000000--00
WebServer/examples/WebUpdate⚠️ +520000000--00
WiFi/examples/FTM/FTM_Initiator⚠️ +320000000--00
WiFi/examples/FTM/FTM_Responder⚠️ +520000000--00
WiFi/examples/SimpleWiFiServer⚠️ +520000000--00
WiFi/examples/WPS⚠️ +520000000--00
WiFi/examples/WiFiAccessPoint⚠️ +520000000--00
WiFi/examples/WiFiBlueToothSwitch⚠️ +560--0000--00
WiFi/examples/WiFiClient⚠️ +480000000--00
WiFi/examples/WiFiClientBasic⚠️ +520000000--00
WiFi/examples/WiFiClientConnect⚠️ +520000000--00
WiFi/examples/WiFiClientEnterprise⚠️ +520000000--00
WiFi/examples/WiFiClientEvents⚠️ +520000000--00
WiFi/examples/WiFiClientStaticIP⚠️ +560000000--00
WiFi/examples/WiFiExtender⚠️ +520000000--00
WiFi/examples/WiFiIPv6⚠️ +520000000--00
WiFi/examples/WiFiMulti⚠️ +520000000--00
WiFi/examples/WiFiMultiAdvanced⚠️ +520000000--00
WiFi/examples/WiFiScan⚠️ +520000000--00
WiFi/examples/WiFiScanAsync⚠️ +520000000--00
WiFi/examples/WiFiScanDualAntenna⚠️ +480000000--00
WiFi/examples/WiFiScanTime⚠️ +520000000--00
WiFi/examples/WiFiSmartConfig⚠️ +520000000--00
WiFi/examples/WiFiTelnetToSerial⚠️ +520000000--00
WiFi/examples/WiFiUDPClient⚠️ +520000000--00
WiFiProv/examples/WiFiProv⚠️ +520000000--00
Wire/examples/WireMaster⚠️ +5200000000000
Wire/examples/WireScan⚠️ +5200000000000
Wire/examples/WireSlave⚠️ +5200000000000
OpenThread/examples/COAP/coap_lamp------0000--
OpenThread/examples/COAP/coap_switch------0000--
OpenThread/examples/SimpleCLI------0000--
OpenThread/examples/SimpleNode------0000--
OpenThread/examples/SimpleThreadNetwork/ExtendedRouterNode------0000--
OpenThread/examples/SimpleThreadNetwork/LeaderNode------0000--
OpenThread/examples/SimpleThreadNetwork/RouterNode------0000--
OpenThread/examples/ThreadScan------0000--
OpenThread/examples/onReceive------0000--
Zigbee/examples/Zigbee_Color_Dimmable_Light------0000--
Zigbee/examples/Zigbee_Color_Dimmer_Switch------0000--
Zigbee/examples/Zigbee_On_Off_Light------0000--
Zigbee/examples/Zigbee_On_Off_Switch------0000--
Zigbee/examples/Zigbee_Scan_Networks------0000--
Zigbee/examples/Zigbee_Temperature_Sensor------0000--
Zigbee/examples/Zigbee_Thermostat------0000--
BluetoothSerial/examples/DiscoverConnect----------00
BluetoothSerial/examples/GetLocalMAC----------00
BluetoothSerial/examples/SerialToSerialBT----------00
BluetoothSerial/examples/SerialToSerialBTM----------00
BluetoothSerial/examples/SerialToSerialBT_Legacy----------00
BluetoothSerial/examples/SerialToSerialBT_SSP----------00
BluetoothSerial/examples/bt_classic_device_discovery----------00
BluetoothSerial/examples/bt_remove_paired_devices----------00
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code----------00
ESP32/examples/Touch/TouchButton----------00
Ethernet/examples/ETH_LAN8720----------00
Ethernet/examples/ETH_TLK110----------00

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Oct 2, 2024
@me-no-dev me-no-dev merged commit ea50cf6 into master Oct 2, 2024
71 checks passed
@me-no-dev me-no-dev deleted the bugfix/opi_psram branch October 2, 2024 19:18
@enjoyneering enjoyneering mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasssvaz lucasssvaz lucasssvaz approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@me-no-dev @lucasssvaz