Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update esp-insights version #10456

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Update esp-insights version #10456

merged 1 commit into from
Oct 15, 2024

Conversation

Asc91
Copy link
Contributor

@Asc91 Asc91 commented Oct 14, 2024

Description of Change

Current esp_insights version in idf_component.yml (^1.0.1) pulls following versions of required components
esp_insights : 1.0.1
esp_diagnostics: 1.0.2
esp_diag_data_store : 1.0.2

With latest update to esp-insights and its components, esp_insights: 1.0.1 is not compatible with esp_diag_data_store: 1.0.2 which causes compilation errors while building core.

Updating esp_insights version to 1.2.1 fixes the issue.

Tests scenarios

Reproduced issue with Arduino-esp32 3.0.5 for ESP32 S3 and ESPC3 boards. After this change build was successful.

Related links

Latest Changes to esp-insights

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update esp-insights version":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello Asc91, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against c6e0855

@VojtechBartoska VojtechBartoska added the Status: Review needed Issue or PR is awaiting review label Oct 14, 2024
@me-no-dev
Copy link
Member

In what case was your build failing? We are reluctant to touch esp-insights, because esp-rainmaker depends on it and it's very easy to break.

@me-no-dev
Copy link
Member

You can also see in this PR that insights is updated to 1.2.1 automatically: #10454 , so when merged, the latest version will be used

me-no-dev
me-no-dev reviewed Oct 15, 2024
View reviewed changes
idf_component.yml
@@ -72,7 +72,7 @@ dependencies:
rules:
- if: "target != esp32c2"
espressif/esp_insights:
version: "^1.0.1"
version: "^1.2.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update esp_rainmaker to 1.5.0

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Oct 15, 2024
@me-no-dev me-no-dev merged commit f8e03cf into espressif:master Oct 15, 2024
21 of 25 checks passed
me-no-dev pushed a commit that referenced this pull request Oct 15, 2024
@Asc91 @me-no-dev
Update esp-insights version (#10456)
32d451d
me-no-dev pushed a commit that referenced this pull request Oct 15, 2024
@Asc91 @me-no-dev
Update esp-insights version (#10456)
c6bf1b4
me-no-dev pushed a commit that referenced this pull request Oct 15, 2024
@Asc91 @me-no-dev
Update esp-insights version (#10456)
1ef10a6
me-no-dev pushed a commit that referenced this pull request Oct 15, 2024
@Asc91 @me-no-dev
Update esp-insights version (#10456)
b3a2e4f
me-no-dev added a commit that referenced this pull request Oct 15, 2024
@me-no-dev @Asc91 @pre-commit-ci-lite
IDF release/v5.3 (#10465)
a3f2568 
* fix(usb): Update tinyusb init call

* Update esp-insights version (#10456)

* Add support for WiFi to ESP32-P4 (#10463)

* feat(p4): Add support for WiFi to ESP32-P4

Implements support for external MCU connected through SDIO

* fix(p4): Init SDIO host properly on Network boot

esp-hosted has one function marked as "constructor" that did not run in the boot phase of the chip. This calls the function when network is started

* Fix RainMaker dependent versions because Matter requires Insights 1.0.1

* IDF release/v5.3 707d097b

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: Mahesh Tupe <tupemahesh91@gmail.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
me-no-dev added a commit that referenced this pull request Oct 15, 2024
@me-no-dev @Asc91
IDF release/v5.1 (#10454)
19cbe8b 
* fix(usb): Use new tusb_init method

* IDF release/v5.1 6dff5b8f

* IDF release/v5.1 632e0c2a

* Update esp-insights version (#10456)

* Update TinyUSB init method

* Update IDF libs size and checksum

Comes also with updated TinyUSB

---------

Co-authored-by: Mahesh Tupe <tupemahesh91@gmail.com>
@Asc91 Asc91 mentioned this pull request Oct 16, 2024
Closed
@Asc91 Asc91 deleted the fix/bump_insights_version branch October 17, 2024 05:38
@Asc91 Asc91 mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Asc91 @CLAassistant @me-no-dev @VojtechBartoska