Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i2s): Use separate variables when reading and writing #10509

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

me-no-dev
Copy link
Member

When reading and writing we should use separate variables for what we are sending/receiving and what has actually been sent/received. Failing to do so may cause wrong data on the output

Copy link
Contributor

Warnings
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 47b7c60

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4000.000.00000.000.00
ESP32S30‼️ +22K0.00‼️ +6.480⚠️ +17880.00‼️ +9.41
ESP32S20‼️ +15K0.00‼️ +5.420⚠️ +14760.00‼️ +10.36
ESP32C30‼️ +14K0.00‼️ +4.330⚠️ +16040.00‼️ +13.00
ESP32C60‼️ +15K0.00‼️ +5.760⚠️ +16520.00‼️ +12.48
ESP32H20‼️ +12K0.00‼️ +3.750⚠️ +15800.00‼️ +11.66
ESP320‼️ +18K0.00‼️ +5.440⚠️ +7280.00‼️ +3.48
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ESP_I2S/examples/ES8388_loopback--‼️ +21K⚠️ +1788‼️ +15K⚠️ +1476‼️ +14K⚠️ +1604‼️ +15K⚠️ +1652‼️ +12K⚠️ +1580‼️ +16K⚠️ +704
ESP_I2S/examples/Record_to_WAV--‼️ +22K⚠️ +1672--------‼️ +18K⚠️ +728
ESP_I2S/examples/Simple_tone--‼️ +19K⚠️ +1648‼️ +14K⚠️ +1424‼️ +11K⚠️ +864‼️ +13K⚠️ +888‼️ +10K⚠️ +816‼️ +16K⚠️ +712

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Test Results

 62 files   62 suites   15m 41s ⏱️
 24 tests  18 ✅ 0 💤 6 ❌
140 runs  134 ✅ 0 💤 6 ❌

For more details on these failures, see this check.

Results for commit 47b7c60.

♻️ This comment has been updated with latest results.

@VojtechBartoska VojtechBartoska added Area: Peripherals API Relates to peripheral's APIs. Status: Review needed Issue or PR is awaiting review labels Oct 23, 2024
@VojtechBartoska VojtechBartoska added this to the 3.1.0-RC2 milestone Oct 23, 2024
@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Oct 23, 2024
@me-no-dev me-no-dev merged commit 6e88445 into release/v3.1.x Oct 23, 2024
74 of 83 checks passed
@me-no-dev me-no-dev deleted the bugfix/i2s_read_write_size branch October 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Peripherals API Relates to peripheral's APIs. Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants