-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i2s): Use separate variables when reading and writing #10509
Conversation
👋 Hello me-no-dev, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Test Results 62 files 62 suites 15m 41s ⏱️ For more details on these failures, see this check. Results for commit 47b7c60. ♻️ This comment has been updated with latest results. |
When reading and writing we should use separate variables for what we are sending/receiving and what has actually been sent/received. Failing to do so may cause wrong data on the output