Add dummy test for self hosted GitHub runners #5521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
me-no-dev
reviewed
Aug 11, 2021
|
|
||
| on: | ||
| push: | ||
| branches: [pull_request] |
There was a problem hiding this comment.
Shouldn't this be
on:
push:
branches:
- master
pull_request:or
on:
pull_request:There was a problem hiding this comment.
@me-no-dev Thanks! I've changed that as proposal(1).
There was a problem hiding this comment.
Now the test ran :) https://github.com/espressif/arduino-esp32/pull/5521/checks?check_run_id=3310070479
Could you sign the CLA too please? GH Checks are complaining
There was a problem hiding this comment.
@me-no-dev Done, thank you. PLS merge it.
hippyaki
reviewed
Sep 3, 2021
this is a test for future use. |
|
This causes CI in forks to fail, because they do not have such a runner. |
jepler
added a commit
to adafruit/arduino-esp32
that referenced
this pull request
Dec 5, 2021
This was added upstream at espressif#5521 and does nothing practical. However, it DOES cause CI to wait for a long time for a matching self-hosted runner.
This was referenced Dec 5, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simple test for newly installed self hosted RPI Github Runners in Espressif Brno site.
Before accepting this PR some selfhosted GH runner must be assigned into project.
Details in https://jira.espressif.com:8443/browse/RDT-43