Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USB CDC] Fix data might not be transmitted until more is written #5652

Merged
merged 2 commits into from
Sep 15, 2021

Conversation

me-no-dev
Copy link
Member

@me-no-dev me-no-dev commented Sep 9, 2021

Depending on tud_cdc_tx_complete_cb can cause in some cases the last packet to not be transmitted until more data is written and flushed. It's a rare case, but if the other end is expecting those last bytes, transmission will hang.

This PR also fixes debug output on CDC

@me-no-dev me-no-dev changed the title Use Ringbuf for CDC write to improve responsiveness and throughput [USB CDC] Fix data might not be transmitted until more is written Sep 15, 2021
@me-no-dev me-no-dev merged commit 541cef9 into master Sep 15, 2021
@me-no-dev me-no-dev deleted the bugfix/cdc_write_halt branch September 15, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant