-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Writing a new Arduino documentation about GPIO #5894
Conversation
@halyssonJr first things first, remove the build folder. I'll check why the |
@halyssonJr please be aware of not adding the unrelated folders and files of your build and environment to the commit. Add only the files that you are working on. Can you clarify why you've changed the |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL at my considerations.
@pedrominatelI, I try to split my commit. So I can't upload just the files I changed. In the next PR I will fix these problems |
@halyssonJr your PR is messed. You suppose to edit only one file but now you have added 191! If you need help to understand the Git flow I'll be glad to help. Currently, your PR is not following the expectations and cant be reviewed. Ping me later if you need help. |
@halyssonJr please take a look at my modifications. |
New version available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Found only one small typo.
Checklist
Summary
Arduino Documentation for GPIO
Impact
None
Co-authored-by: Pedro Minatel pminatel@gmail.com