Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Editing usage of Arduino as a component in ESP-IDF #5896

Merged
merged 3 commits into from
Nov 22, 2021
Merged

[DOCS] Editing usage of Arduino as a component in ESP-IDF #5896

merged 3 commits into from
Nov 22, 2021

Conversation

P-R-O-C-H-Y
Copy link
Member

Summary

Fixed link to lib-builder.
Divided "usage" to 2 options (in 1 you have to change main.c to main.cpp).
Some styling fixes.

Impact

None.

@VojtechBartoska
Copy link
Contributor

included in #5839

@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label Nov 16, 2021
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Nov 16, 2021
pedrominatel
pedrominatel requested changes Nov 16, 2021
View reviewed changes
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL at my considerations.

docs/source/esp-idf_component.rst Outdated Show resolved Hide resolved
docs/source/esp-idf_component.rst Outdated Show resolved Hide resolved
@pedrominatel
Copy link
Member

LGTM @P-R-O-C-H-Y. Thank you!

@pedrominatel pedrominatel merged commit 399f4ec into espressif:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VojtechBartoska VojtechBartoska VojtechBartoska approved these changes

@pedrominatel pedrominatel pedrominatel approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P-R-O-C-H-Y @VojtechBartoska @pedrominatel