-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GPIO defines for C3 #6005
add GPIO defines for C3 #6005
Conversation
Hello, I changed the code to the code you updated, but the problem still appears. |
@GYSS1204 Try this complete Arduino framework. It is builded on latest IDF4.4 and latest Arduino master including this change. It does work with my C3.
|
I am a bit confused how this change helps (apart from maybe the adc init). For C3 |
@me-no-dev Perhaps it would simplify it if all architectures defined |
@atanisoft that will have to be tested once we move all other peripherals to IDF API. It is the end goal though :) |
cores/esp32/esp32-hal-gpio.c
Outdated
@@ -192,7 +221,7 @@ extern void ARDUINO_ISR_ATTR __pinMode(uint8_t pin, uint8_t mode) | |||
#endif | |||
} else if(mode == ANALOG){ | |||
#if !CONFIG_IDF_TARGET_ESP32C3 | |||
//adc_gpio_init(ADC_UNIT_1, ADC_CHANNEL_0); | |||
adc_gpio_init(ADC_UNIT_1, ADC_CHANNEL_0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any specific reason for uncommenting this line? :)
Don't have any effect on the esp32c3
Problem: #5502 (comment)
Solution: tasmota#31 from @Jason2866