Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GPIO defines for C3 #6005

Merged
merged 3 commits into from
Dec 22, 2021
Merged

add GPIO defines for C3 #6005

merged 3 commits into from
Dec 22, 2021

Conversation

NiklasVoigt
Copy link
Contributor

Problem: #5502 (comment)
Solution: tasmota#31 from @Jason2866

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2021

CLA assistant check
All committers have signed the CLA.

@GYSS1204
Copy link

Hello, I changed the code to the code you updated, but the problem still appears.

@Jason2866
Copy link
Collaborator

@GYSS1204 Try this complete Arduino framework. It is builded on latest IDF4.4 and latest Arduino master including this change. It does work with my C3.
Platformio setup

platform                    = https://github.com/tasmota/platform-espressif32.git#feature/arduino-idf-v4.4
platform_packages           = framework-arduinoespressif32 @ https://github.com/Jason2866/esp32-arduino-lib-builder/releases/download/532/framework-arduinoespressif32-release_v4.4-c3ff20355.tar.gz

@me-no-dev
Copy link
Member

I am a bit confused how this change helps (apart from maybe the adc init). For C3 USE_ESP_IDF_GPIO is defined as 1, so it never uses the mux table.

@atanisoft
Copy link
Collaborator

atanisoft commented Dec 14, 2021

@me-no-dev Perhaps it would simplify it if all architectures defined USE_ESP_IDF_GPIO to 1

@me-no-dev
Copy link
Member

@atanisoft that will have to be tested once we move all other peripherals to IDF API. It is the end goal though :)

@VojtechBartoska VojtechBartoska added the Status: Test needed Issue needs testing label Dec 20, 2021
@VojtechBartoska VojtechBartoska added this to the 2.0.2 milestone Dec 20, 2021
@@ -192,7 +221,7 @@ extern void ARDUINO_ISR_ATTR __pinMode(uint8_t pin, uint8_t mode)
#endif
} else if(mode == ANALOG){
#if !CONFIG_IDF_TARGET_ESP32C3
//adc_gpio_init(ADC_UNIT_1, ADC_CHANNEL_0);
adc_gpio_init(ADC_UNIT_1, ADC_CHANNEL_0);
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any specific reason for uncommenting this line? :)
Don't have any effect on the esp32c3

@me-no-dev me-no-dev merged commit 8c88ecb into espressif:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Test needed Issue needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants