Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently change device index to singed integer in BluetoothSerial lib #6109

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Consistently change device index to singed integer in BluetoothSerial lib #6109

merged 2 commits into from
Jan 17, 2022

Commits on Jan 7, 2022

  1. change parameter to signed int 

    As of wrong paramater, the following problem existed, that will be fixed now with this change.

BTScanResultsSet.cpp:67:8: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if (i < 0)
    @iltis42
    iltis42 authored Jan 7, 2022
    Configuration menu
    Copy the full SHA
    3f9ca97 View commit details
    Browse the repository at this point in the history

  2. Change parameter and variable to int 

    As of wrong paramater, the following problem existed, that will be fixed now with this change.

BTScanResultsSet.cpp:67:8: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if (i < 0)
    @iltis42
    iltis42 authored Jan 7, 2022
    Configuration menu
    Copy the full SHA
    9bd423e View commit details
    Browse the repository at this point in the history