Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX - FS.read / seek fixes #6536

Closed
wants to merge 4 commits into from
Closed

BUGFIX - FS.read / seek fixes #6536

wants to merge 4 commits into from

Conversation

P-R-O-C-H-Y
Copy link
Member

Summary

Fixed previously changed implementation of VFSFileImpl::read.

Still known issue with SDWebServer.

Impact

Fixing SD lib / LittleFS lib / ... to be tested

Related links

Please provide links to related issue, PRs etc.

@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 2.0.3 milestone Apr 5, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Apr 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022 •
edited
Loading

Unit Test Results

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit b6b8763.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request Apr 5, 2022
Closed
1 task
@P-R-O-C-H-Y
Copy link
Member Author

This solution ends with unexpected behaviour with mixing together low level unbuffered read with buffered fread

@P-R-O-C-H-Y P-R-O-C-H-Y closed this Apr 8, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y deleted the FS-read-bugfix branch April 19, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
None yet
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
1 participant
@P-R-O-C-H-Y