Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Added partition table tutorial #6758

Merged

Conversation

pedrominatel
Copy link
Member

@pedrominatel pedrominatel commented May 16, 2022

Description of Change

This PR adds the partition table details and the steps for creating a custom one.

Tests scenarios

N/A

Related links

Closes #4551
Closes #6495

@pedrominatel pedrominatel added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label May 16, 2022
@pedrominatel pedrominatel self-assigned this May 16, 2022
@pedrominatel pedrominatel requested a review from me-no-dev May 18, 2022 14:04
@VojtechBartoska
Copy link
Contributor

Can solve also #6495?

Copy link
Contributor

@VojtechBartoska VojtechBartoska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @pedrominatel!

Left few comments (just suggestion to be added up to your opinion).

docs/source/tutorials/partition_table.rst Outdated Show resolved Hide resolved
docs/source/tutorials/partition_table.rst Outdated Show resolved Hide resolved
docs/source/tutorials/partition_table.rst Outdated Show resolved Hide resolved

The SubType defines the usage of the ``app`` and ``data`` partitions.

**data**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are some of subtypes mandatory? I see some are optional (maybe we can highlight this more?)

This is maybe not valid questions as more experienced Devs are going to add their custom partition table scheme.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will depend if you need OTA or not.

docs/source/tutorials/partition_table.rst Outdated Show resolved Hide resolved
docs/source/tutorials/partition_table.rst Outdated Show resolved Hide resolved
@pedrominatel
Copy link
Member Author

PTAL @VojtechBartoska

@VojtechBartoska
Copy link
Contributor

LGTM!

@me-no-dev me-no-dev merged commit 33011ed into espressif:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
3 participants