WiFi.disconnect() "aligned with Aduino.cc". waiting for status change.

[JAndrassy]

WiFi.disconnect() "aligned with Aduino.cc".
WiFi.disconnect renamed to disconnectAsync
new WiFi.disconnect waits for status change

the WiFi library with async disconnect behaves very strange. after disconnect() and immediate WiFi.begin it can't connect. I had to add a wait for status change after disconnect in my test sketch.
So I think the blocking version of disconnect() is a better option for everybody. It is quick.

[github-actions]

Warnings

⚠️

Some issues found for the commit messages in this PR: the commit message "WiFi.disconnect() "aligned with Aduino.cc". waiting for status change.": summary should not end with a period (full stop) summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello JAndrassy, we appreciate your contribution to this project!

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8fa2724

[TD-er]

Just something to consider.
wl_status_t WiFiSTAClass::begin(const char* ssid, const char *passphrase, int32_t channel, const uint8_t* bssid, bool connect) is also calling esp_wifi_disconnect().
So instead of letting the user take care of async vs "waiting for' disconnect, shouldn't the begin() call take care of this?

Also all begin() calls do check for quite a lot of things but the only return state in case of an error is WL_CONNECT_FAILED.
Not really informative.

[JAndrassy]

the state changes takes less than 1 millisecond.
disconnectAsync takes.2 milliseconds