Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update m5stack boards define #9086

Merged
merged 4 commits into from
Jan 19, 2024
Merged

update m5stack boards define #9086

merged 4 commits into from
Jan 19, 2024

Conversation

Gitshaoxiang
Copy link
Contributor

Description of Change

For better maintenance, we have made some changes
Unified the naming of M5Stack boards, modified some board default partition table options(solved some example app size too big), also enabled the S3 board default CDC option, and added some new board options and custom partition tables.

Tests scenarios

These changes were tested on our official board management
https://m5stack.oss-cn-shenzhen.aliyuncs.com/resource/arduino/package_m5stack_index_dev.json

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "add M5Dial Board":
    • summary looks empty
    • type/action looks empty
  • the commit message "build.board modify uppercase":
    • summary looks empty
    • type/action looks empty
  • the commit message "update m5stack boards define":
    • summary looks empty
    • type/action looks empty
  • the commit message "update pins define":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).
📖 This PR seems to be quite large (total lines of code: 5990), you might consider splitting it into smaller PRs

👋 Hello Gitshaoxiang, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against e1bd05c

Comment on lines 6 to 12
#define EXTERNAL_NUM_INTERRUPTS 16
#define NUM_DIGITAL_PINS 40
#define NUM_ANALOG_INPUTS 16

#define analogInputToDigitalPin(p) (((p)<20)?(esp32_adc2gpio[(p)]):-1)
#define digitalPinToInterrupt(p) (((p)<40)?(p):-1)
#define digitalPinHasPWM(p) (p < 34)
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gitshaoxiang Please remove this part from all pins_arduino.h files of your boards.
These #defines are now defined globally per SoC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply, new changes have been committed now

@me-no-dev
Copy link
Member

@P-R-O-C-H-Y PTAL

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gitshaoxiang The <board>.build.board= parameter must be uppercase. Please change it in all your boards.

boards.txt Show resolved Hide resolved
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Jan 19, 2024
@me-no-dev me-no-dev merged commit a1c86ae into espressif:master Jan 19, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants