-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update m5stack boards define #9086
Conversation
👋 Hello Gitshaoxiang, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
variants/m5stack_atom/pins_arduino.h
Outdated
#define EXTERNAL_NUM_INTERRUPTS 16 | ||
#define NUM_DIGITAL_PINS 40 | ||
#define NUM_ANALOG_INPUTS 16 | ||
|
||
#define analogInputToDigitalPin(p) (((p)<20)?(esp32_adc2gpio[(p)]):-1) | ||
#define digitalPinToInterrupt(p) (((p)<40)?(p):-1) | ||
#define digitalPinHasPWM(p) (p < 34) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gitshaoxiang Please remove this part from all pins_arduino.h files of your boards.
These #defines are now defined globally per SoC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your reply, new changes have been committed now
@P-R-O-C-H-Y PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gitshaoxiang The <board>.build.board=
parameter must be uppercase. Please change it in all your boards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :) LGTM
Description of Change
For better maintenance, we have made some changes
Unified the naming of M5Stack boards, modified some board default partition table options(solved some example app size too big), also enabled the S3 board default CDC option, and added some new board options and custom partition tables.
Tests scenarios
These changes were tested on our official board management
https://m5stack.oss-cn-shenzhen.aliyuncs.com/resource/arduino/package_m5stack_index_dev.json