Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include for SemaphoreHandle_t to LEDC header file #9134

Merged

Conversation

sgryphon
Copy link
Contributor

Description of Change

Add missing include references to esp32-hal-ledc.h for type SemaphoreHandle_t

This header is used by the M5Unified library, via M5GFX, in the Light_PWM.cpp file and in that context does not have the required FreeRTOS semaphore type, so the build/compile fails. Files should generally include the references they use and not rely on other files having included necessary headers prior to them (in case they are loaded in a different order).

This is a minor change.

Tests scenarios

Tested on M5Stack Core2 (ESP32). Note that this is a compilation error, so can be reproduced without board (although after fixing I did test the sample ran). Sample code is in the bug report.

Related links

Fixes #9133


By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable - no relevant documentation
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.

Copy link
Contributor

github-actions bot commented Jan 18, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello sgryphon, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against e8ecaa1

@me-no-dev me-no-dev merged commit dd712db into espressif:master Jan 19, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LEDC missing SemaphoreHandle_t (alpha 3 issue) building for M5Stack Core
3 participants