Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LittleFS as partition type to debug report #9354

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

Jason2866
Copy link
Collaborator

LittleFS has its own Partition Sub Type. Follow up of #9340

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "add LittleFS as partition type":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 5 commits (simplifying branch history).

👋 Hello Jason2866, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against ea43bf9

@VojtechBartoska
Copy link
Collaborator

Thanks @Jason2866 for PR, CI does not like this proposal so far 😃

@Jason2866
Copy link
Collaborator Author

@VojtechBartoska Yes, since the actual compiled libs are based on not actual IDF 5.1
It will compile if the are getting updated :-)

@Jason2866
Copy link
Collaborator Author

Jason2866 commented Mar 13, 2024

Closing since we latest changes the LittleFS support in IDF has been removed
tasmota/esp-idf@0cbe0e0

Probably in favour of tasmota/esp-idf@5627333
which will be backported?

@Jason2866 Jason2866 closed this Mar 13, 2024
@Jason2866
Copy link
Collaborator Author

Reopened since LittleFS is back in IDF5.1 espressif/esp-idf@f210386

@Jason2866 Jason2866 reopened this Mar 15, 2024
@lucasssvaz lucasssvaz added Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first and removed Status: Blocked by ESP-IDF labels Apr 2, 2024
@lucasssvaz lucasssvaz added Status: Pending Merge Pull Request is ready to be merged and removed Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first labels Apr 15, 2024
@me-no-dev me-no-dev merged commit 9caa363 into espressif:master Apr 15, 2024
48 checks passed
P-R-O-C-H-Y pushed a commit to P-R-O-C-H-Y/arduino-esp32 that referenced this pull request Apr 16, 2024
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
@Jason2866 Jason2866 deleted the patch-2 branch April 16, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: ESP-IDF related ESP-IDF related issues Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants