Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wifi): Add support for NAPT to WIFI AP #9478

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

me-no-dev
Copy link
Member

@me-no-dev me-no-dev commented Apr 10, 2024

Allows another interface's connection to be shared to the AP

Test code:

void testAP(){
  IPAddress ip(192, 168, 0, 1);
  IPAddress gw(192, 168, 0, 1);
  IPAddress mask(255, 255, 255, 0);
  IPAddress leaseStart(192, 168, 0, 2);
  IPAddress dns(8, 8, 4, 4);//or the DNS from the outgoing interface
  WiFi.softAPConfig(ip, gw, mask, leaseStart, dns);
  WiFi.softAP(WiFi.getHostname());
  while(!WiFi.AP.started()) delay(10);
  if(!WiFi.AP.enableNAPT()){
    Serial.println("Failed to enable NAPT");  
  }
}

Allows another interface's connection to be shared to the AP
Copy link
Contributor

github-actions bot commented Apr 10, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 908a0b2

@me-no-dev me-no-dev merged commit 8c75c35 into master Apr 10, 2024
41 checks passed
@me-no-dev me-no-dev deleted the feature/wifi_napt branch April 10, 2024 12:09
P-R-O-C-H-Y pushed a commit to P-R-O-C-H-Y/arduino-esp32 that referenced this pull request Apr 16, 2024
Allows another interface's connection to be shared to the AP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant