Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(roboheart): Update of LED_ROBOHEART in RoboHeart Hercules pins… #9494

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

evgenimelan
Copy link
Contributor

The built-in "Blink" LED on the new version of the RoboHeart development board is connected to IO13 instead of IO14.

I am one of the founders of Augmented Robotics who oversees design and production of RoboHeart Hercules, see website: https://augmented-robotics.com/index.php/roboheart-hercules/

I am also the maintainer of the original RoboHeart Hercules Arduino library repository on github: https://github.com/Augmented-Robotics/roboheart-arduino-library


Description of Change

Please describe your proposed Pull Request and it's impact.
It changes the pin definition of the built-in LED on the RoboHeart Hercules board. In the new version the built-in LED is connected to IO13 instead of IO14. This change only impacts the RoboHeart Hercules board by Augmented Robotics.

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
I have tested my Pull Request on Arduino-esp32 core v2.0.15 with the RoboHeart Hercules Board v0.6L, which uses ESP32-WROOM-32E as its main microcontroller.

Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello evgenimelan, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 430f1f4

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Apr 15, 2024
@me-no-dev me-no-dev merged commit 0596733 into espressif:master Apr 15, 2024
49 checks passed
P-R-O-C-H-Y pushed a commit to P-R-O-C-H-Y/arduino-esp32 that referenced this pull request Apr 16, 2024
@evgenimelan
Copy link
Contributor Author

Hello, I see that the status is "pending merge" can you tell me whether it is planned to be merged in the next release? 2.0.17
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants