-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eth): Attach ETH events at the correct place #9658
Conversation
This is to ensure that stack events are called before ours, because callbacks are called in order of attaching
👋 Hello me-no-dev, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
* fix(eth): Attach ETH events at the correct place (espressif#9658) This is to ensure that stack events are called before ours, because callbacks are called in order of attaching * feat(eth): Enable the possibility to use SPI ETH with only 4 wires (espressif#9659) This PR enables ETH_SPI_SUPPORTS_NO_IRQ to support connection by only 4 wires (SCK, MISO, MOSI and SS) with IRQ and RESET being set as -1 * fix(eth): Fix ETH.end() (espressif#9661) * fix(eth): Fix ETH.end() * fix(eth): set glue handle to NULL --------- Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
This is to ensure that stack events are called before ours, because callbacks are called in order of attaching