-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(refactor): Refactor workflows and skip files #9696
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@lucasssvaz Any link to some run on local fork to check? :) |
@lucasssvaz you can pull master to get the updated get.py |
Description of Change
This PR refactors many things inside our tests and CI:
ci.json
to control how the CI will handle the sketchgithub-actions[bot]
to commitThis PR will require changing the required checks for the branch protection rules.
Caution
As the new
tests.yml
workflow usespull_request_target
, the defaultGITHUB_TOKEN
permissions are set only tocontents: read
. Higher permissions are given in a per job basis. PLEASE MAKE SURE TO PROPERLY REVIEW IF THERE IS NO POSSIBLE POINT OF VULNERABILITYTests scenarios
Tested in local fork
Note
The PR CI will likely fail as the scripts changed but the workflow changes will only be effective after merging.