Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(net): Don't unregister events if there are interfaces still open #9706

Merged
merged 3 commits into from
May 29, 2024
Merged

fix(net): Don't unregister events if there are interfaces still open #9706

merged 3 commits into from
May 29, 2024

Conversation

me-no-dev
Copy link
Member

Unregister IP events only if all other netifs are stopped.

cc: @JAndrassy

@me-no-dev
fix(net): Don't unreg events if there are netifs
5b47272 
Unregister IP events only if all other netifs are stopped.
@me-no-dev me-no-dev added this to the 3.0.1 milestone May 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 28, 2024 •
edited
Loading

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello me-no-dev, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against a856b26

@me-no-dev me-no-dev changed the title fix(net): Don't unreg events if there are netifs fix(net): Don't unregister events if there are interfaces still open May 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 28, 2024 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit a856b26.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 28, 2024 •
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +3440.00⚠️ +0.060⚠️ +160.00⚠️ +0.08
ESP32S20⚠️ +3400.00⚠️ +0.070⚠️ +240.00⚠️ +0.15
ESP32C30⚠️ +3800.00⚠️ +0.070⚠️ +160.00⚠️ +0.11
ESP32C60⚠️ +3800.00⚠️ +0.080⚠️ +160.00⚠️ +0.11
ESP32H20⚠️ +3760.00⚠️ +0.070⚠️ +160.00⚠️ +0.11
ESP320⚠️ +3600.00⚠️ +0.070⚠️ +240.00⚠️ +0.11
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ArduinoOTA/examples/BasicOTA⚠️ +480⚠️ +520⚠️ +700⚠️ +700--⚠️ +520
AsyncUDP/examples/AsyncUDPClient⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +440
AsyncUDP/examples/AsyncUDPMulticastServer⚠️ +400⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
AsyncUDP/examples/AsyncUDPServer⚠️ +400⚠️ +480⚠️ +680⚠️ +680--⚠️ +400
BLE/examples/BLE5_extended_scan00--000000--
BLE/examples/BLE5_multi_advertising00--000000--
BLE/examples/BLE5_periodic_advertising00--000000--
BLE/examples/BLE5_periodic_sync00--000000--
BLE/examples/Beacon_Scanner00--00000000
BLE/examples/Client00--00000000
BLE/examples/EddystoneTLM_Beacon00--0000--00
BLE/examples/EddystoneURL_Beacon00--0000--00
BLE/examples/Notify00--00000000
BLE/examples/Scan00--00000000
BLE/examples/Server00--00000000
BLE/examples/Server_multiconnect00--00000000
BLE/examples/UART00--00000000
BLE/examples/Write00--00000000
BLE/examples/iBeacon00--00000000
DNSServer/examples/CaptivePortal⚠️ +400⚠️ +440⚠️ +740⚠️ +720--⚠️ +560
EEPROM/examples/eeprom_class000000000000
EEPROM/examples/eeprom_extra000000000000
EEPROM/examples/eeprom_write000000000000
ESP32/examples/AnalogOut/LEDCFade000000000000
ESP32/examples/AnalogOut/LEDCSoftwareFade000000000000
ESP32/examples/AnalogOut/SigmaDelta000000000000
ESP32/examples/AnalogOut/ledcFrequency000000000000
ESP32/examples/AnalogOut/ledcWrite_RGB000000000000
ESP32/examples/AnalogRead000000000000
ESP32/examples/AnalogReadContinuous000000000000
ESP32/examples/ArduinoStackSize000000000000
ESP32/examples/CI/CIBoardsTest000000000000
ESP32/examples/Camera/CameraWebServer⚠️ +480⚠️ +560------⚠️ +480
ESP32/examples/ChipID/GetChipID000000000000
ESP32/examples/DeepSleep/ExternalWakeUp0000------00
ESP32/examples/DeepSleep/TimerWakeUp00000000--00
ESP32/examples/DeepSleep/TouchWakeUp0000------00
ESP32/examples/FreeRTOS/BasicMultiThreading000000000000
ESP32/examples/FreeRTOS/Mutex000000000000
ESP32/examples/FreeRTOS/Queue000000000000
ESP32/examples/FreeRTOS/Semaphore000000000000
ESP32/examples/GPIO/BlinkRGB000000000000
ESP32/examples/GPIO/FunctionalInterrupt000000000000
ESP32/examples/GPIO/FunctionalInterruptStruct000000000000
ESP32/examples/GPIO/GPIOInterrupt000000000000
ESP32/examples/HWCDC_Events00--000000--
ESP32/examples/MacAddress/GetMacAddress000000000000
ESP32/examples/RMT/RMTCallback000000000000
ESP32/examples/RMT/RMTLoopback000000000000
ESP32/examples/RMT/RMTReadXJT000000000000
ESP32/examples/RMT/RMTWriteNeoPixel000000000000
ESP32/examples/RMT/RMT_CPUFreq_Test000000000000
ESP32/examples/RMT/RMT_EndOfTransmissionState000000000000
ESP32/examples/RMT/RMT_LED_Blink000000000000
ESP32/examples/ResetReason/ResetReason000000000000
ESP32/examples/ResetReason/ResetReason2000000000000
ESP32/examples/Serial/BaudRateDetect_Demo000000000000
ESP32/examples/Serial/OnReceiveError_BREAK_Demo000000000000
ESP32/examples/Serial/OnReceive_Demo000000000000
ESP32/examples/Serial/RS485_Echo_Demo000000000000
ESP32/examples/Serial/RxFIFOFull_Demo000000000000
ESP32/examples/Serial/RxTimeout_Demo000000000000
ESP32/examples/Serial/Serial_All_CPU_Freqs000000000000
ESP32/examples/Serial/Serial_STD_Func_OnReceive000000000000
ESP32/examples/Serial/onReceiveExample000000000000
ESP32/examples/TWAI/TWAIreceive000000000000
ESP32/examples/TWAI/TWAItransmit000000000000
ESP32/examples/Template/ExampleTemplate000000000000
ESP32/examples/Time/SimpleTime⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
ESP32/examples/Timer/RepeatTimer000000000000
ESP32/examples/Timer/WatchdogTimer000000000000
ESP32/examples/Touch/TouchButtonV20000--------
ESP32/examples/Touch/TouchInterrupt0000------00
ESP32/examples/Touch/TouchRead0000------00
ESP32/examples/Utilities/HEXBuilder000000000000
ESP32/examples/Utilities/MD5Builder000000000000
ESP32/examples/Utilities/SHA1Builder000000000000
ESP_I2S/examples/ES8388_loopback000000000000
ESP_I2S/examples/Record_to_WAV00--------00
ESP_I2S/examples/Simple_tone000000000000
ESP_NOW/examples/ESP_NOW_Broadcast_Master⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +600
ESP_NOW/examples/ESP_NOW_Broadcast_Slave⚠️ +440⚠️ +480⚠️ +700⚠️ +700--⚠️ +520
ESP_NOW/examples/ESP_NOW_Network⚠️ +520⚠️ +480⚠️ +700⚠️ +680--⚠️ +560
ESP_NOW/examples/ESP_NOW_Serial⚠️ +440⚠️ +520⚠️ +680⚠️ +680--⚠️ +520
ESP_SR/examples/Basic00----------
ESPmDNS/examples/mDNS-SD_Extended⚠️ +480⚠️ +480⚠️ +700⚠️ +700--⚠️ +360
ESPmDNS/examples/mDNS_Web_Server⚠️ +480⚠️ +520⚠️ +680⚠️ +680--⚠️ +520
Ethernet/examples/ETH_W5500_Arduino_SPI⚠️ +340⚠️ +16⚠️ +320⚠️ +24⚠️ +380⚠️ +16⚠️ +380⚠️ +16⚠️ +376⚠️ +16⚠️ +352⚠️ +24
Ethernet/examples/ETH_W5500_IDF_SPI⚠️ +344⚠️ +16⚠️ +340⚠️ +24⚠️ +380⚠️ +16⚠️ +380⚠️ +16⚠️ +376⚠️ +16⚠️ +360⚠️ +24
FFat/examples/FFat_Test000000000000
FFat/examples/FFat_time⚠️ +440⚠️ +440⚠️ +680⚠️ +680--⚠️ +520
HTTPClient/examples/Authorization⚠️ +520⚠️ +480⚠️ +680⚠️ +680--⚠️ +600
HTTPClient/examples/BasicHttpClient⚠️ +520⚠️ +480⚠️ +680⚠️ +680--⚠️ +600
HTTPClient/examples/BasicHttpsClient⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
HTTPClient/examples/HTTPClientEnterprise⚠️ +480⚠️ +480⚠️ +720⚠️ +700--⚠️ +520
HTTPClient/examples/ReuseConnection⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
HTTPClient/examples/StreamHttpClient⚠️ +480⚠️ +480⚠️ +700⚠️ +700--⚠️ +520
HTTPUpdate/examples/httpUpdate⚠️ +480⚠️ +280⚠️ +680⚠️ +680--⚠️ +520
HTTPUpdate/examples/httpUpdateSPIFFS⚠️ +480⚠️ +480⚠️ +700⚠️ +700--⚠️ +560
HTTPUpdate/examples/httpUpdateSecure⚠️ +520⚠️ +600⚠️ +680⚠️ +680--⚠️ +520
HTTPUpdateServer/examples/WebUpdater⚠️ +480⚠️ +560⚠️ +680⚠️ +680--⚠️ +520
Insights/examples/DiagnosticsSmokeTest⚠️ +480⚠️ +520⚠️ +680----⚠️ +520
Insights/examples/MinimalDiagnostics⚠️ +480⚠️ +360⚠️ +680----⚠️ +560
LittleFS/examples/LITTLEFS_test000000000000
LittleFS/examples/LITTLEFS_time⚠️ +360⚠️ +520⚠️ +680⚠️ +680--⚠️ +640
NetBIOS/examples/ESP_NBNST⚠️ +520⚠️ +480⚠️ +680⚠️ +680--⚠️ +360
NetworkClientSecure/examples/WiFiClientInsecure⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +400
NetworkClientSecure/examples/WiFiClientPSK⚠️ +480⚠️ +520⚠️ +680⚠️ +680--⚠️ +520
NetworkClientSecure/examples/WiFiClientSecure⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +400
NetworkClientSecure/examples/WiFiClientSecureEnterprise⚠️ +480⚠️ +520⚠️ +740⚠️ +740--⚠️ +520
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade⚠️ +480⚠️ +520⚠️ +720⚠️ +700--⚠️ +520
NetworkClientSecure/examples/WiFiClientShowPeerCredentials⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +560
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse⚠️ +480⚠️ +520⚠️ +680⚠️ +700--⚠️ +520
PPP/examples/PPP_Basic⚠️ +1320⚠️ +1320⚠️ +1820⚠️ +1840⚠️ +1800⚠️ +1440
Preferences/examples/Prefs2Struct000000000000
Preferences/examples/StartCounter000000000000
RainMaker/examples/RMakerCustom⚠️ +480⚠️ +520⚠️ +700----⚠️ +520
RainMaker/examples/RMakerCustomAirCooler⚠️ +520⚠️ +480⚠️ +680----⚠️ +520
RainMaker/examples/RMakerSonoffDualR3⚠️ +480⚠️ +480⚠️ +700----⚠️ +560
RainMaker/examples/RMakerSwitch⚠️ +240⚠️ +480⚠️ +680----⚠️ +520
SD/examples/SD_Test000000000000
SD/examples/SD_time⚠️ +480⚠️ +560⚠️ +680⚠️ +680--⚠️ +520
SD_MMC/examples/SDMMC_Test00--------00
SD_MMC/examples/SDMMC_time⚠️ +480--------⚠️ +520
SPI/examples/SPI_Multiple_Buses0000------00
SPIFFS/examples/SPIFFS_Test000000000000
SPIFFS/examples/SPIFFS_time⚠️ +440⚠️ +480⚠️ +680⚠️ +680--⚠️ +560
SimpleBLE/examples/SimpleBleDevice00----000000
TFLiteMicro/examples/hello_world000000000000
Ticker/examples/Blinker000000000000
Ticker/examples/TickerBasic000000000000
Ticker/examples/TickerParameter000000000000
USB/examples/CompositeDevice0000--------
USB/examples/ConsumerControl0000--------
USB/examples/CustomHIDDevice0000--------
USB/examples/FirmwareMSC0000--------
USB/examples/Gamepad0000--------
USB/examples/HIDVendor0000--------
USB/examples/Keyboard/KeyboardLogout0000--------
USB/examples/Keyboard/KeyboardMessage0000--------
USB/examples/Keyboard/KeyboardReprogram0000--------
USB/examples/Keyboard/KeyboardSerial0000--------
USB/examples/KeyboardAndMouseControl0000--------
USB/examples/MIDI/MidiController0000--------
USB/examples/MIDI/MidiInterface0000--------
USB/examples/MIDI/MidiMusicBox0000--------
USB/examples/MIDI/ReceiveMidi0000--------
USB/examples/Mouse/ButtonMouseControl0000--------
USB/examples/SystemControl0000--------
USB/examples/USBMSC0000--------
USB/examples/USBSerial0000--------
USB/examples/USBVendor0000--------
Update/examples/AWS_S3_OTA_Update⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
Update/examples/HTTPS_OTA_Update⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +560
Update/examples/HTTP_Client_AES_OTA_Update⚠️ +480⚠️ +560⚠️ +680⚠️ +680--⚠️ +520
Update/examples/HTTP_Server_AES_OTA_Update⚠️ +480⚠️ +520⚠️ +680⚠️ +680--⚠️ +520
Update/examples/OTAWebUpdater⚠️ +400⚠️ +520⚠️ +680⚠️ +680--⚠️ +520
Update/examples/SD_Update000000000000
WebServer/examples/AdvancedWebServer⚠️ +480⚠️ +520⚠️ +700⚠️ +700--⚠️ +520
WebServer/examples/FSBrowser⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
WebServer/examples/HelloServer⚠️ +480⚠️ +600⚠️ +680⚠️ +680--⚠️ +520
WebServer/examples/HttpAdvancedAuth⚠️ +480⚠️ +480⚠️ +720⚠️ +720--⚠️ +520
WebServer/examples/HttpAuthCallback⚠️ +560⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
WebServer/examples/HttpAuthCallbackInline⚠️ +480⚠️ +480⚠️ +740⚠️ +740--⚠️ +520
WebServer/examples/HttpBasicAuth⚠️ +320⚠️ +480⚠️ +720⚠️ +720--⚠️ +520
WebServer/examples/HttpBasicAuthSHA1⚠️ +480⚠️ +480⚠️ +740⚠️ +740--⚠️ +520
WebServer/examples/HttpBasicAuthSHA1orBearerToken⚠️ +440⚠️ +480⚠️ +680⚠️ +680--⚠️ +640
WebServer/examples/MultiHomedServers⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +640
WebServer/examples/PathArgServer⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
WebServer/examples/SDWebServer⚠️ +520⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
WebServer/examples/SimpleAuthentification⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
WebServer/examples/UploadHugeFile⚠️ +560⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
WebServer/examples/WebServer⚠️ +480⚠️ +520⚠️ +680⚠️ +680--⚠️ +520
WebServer/examples/WebUpdate⚠️ +480⚠️ +440⚠️ +680⚠️ +680--⚠️ +520
WiFi/examples/FTM/FTM_Initiator⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
WiFi/examples/FTM/FTM_Responder⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +280
WiFi/examples/SimpleWiFiServer⚠️ +520⚠️ +560⚠️ +740⚠️ +740--⚠️ +400
WiFi/examples/WPS⚠️ +120⚠️ +400⚠️ +680⚠️ +680--⚠️ +520
WiFi/examples/WiFiAccessPoint⚠️ +520⚠️ +520⚠️ +740⚠️ +720--⚠️ +320
WiFi/examples/WiFiBlueToothSwitch⚠️ +480--⚠️ +680⚠️ +680--⚠️ +520
WiFi/examples/WiFiClient⚠️ +360⚠️ +520⚠️ +700⚠️ +700--⚠️ +520
WiFi/examples/WiFiClientBasic⚠️ +520⚠️ +280⚠️ +700⚠️ +700--⚠️ +600
WiFi/examples/WiFiClientConnect⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
WiFi/examples/WiFiClientEnterprise⚠️ +400⚠️ +520⚠️ +700⚠️ +700--⚠️ +600
WiFi/examples/WiFiClientEvents⚠️ +480⚠️ +560⚠️ +680⚠️ +680--⚠️ +520
WiFi/examples/WiFiClientStaticIP⚠️ +240⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
WiFi/examples/WiFiIPv6⚠️ +480⚠️ +480⚠️ +700⚠️ +700--⚠️ +520
WiFi/examples/WiFiMulti⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +560
WiFi/examples/WiFiMultiAdvanced⚠️ +480⚠️ +480⚠️ +700⚠️ +700--⚠️ +480
WiFi/examples/WiFiScan⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
WiFi/examples/WiFiScanAsync⚠️ +480⚠️ +480⚠️ +700⚠️ +680--⚠️ +440
WiFi/examples/WiFiScanDualAntenna⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +400
WiFi/examples/WiFiSmartConfig⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
WiFi/examples/WiFiTelnetToSerial⚠️ +480⚠️ +560⚠️ +680⚠️ +680--⚠️ +520
WiFi/examples/WiFiUDPClient⚠️ +520⚠️ +480⚠️ +680⚠️ +680--⚠️ +520
WiFiProv/examples/WiFiProv⚠️ +480⚠️ +480⚠️ +680⚠️ +680--⚠️ +560
Wire/examples/WireMaster000000000000
Wire/examples/WireScan000000000000
Wire/examples/WireSlave000000000000
BluetoothSerial/examples/DiscoverConnect----------00
BluetoothSerial/examples/GetLocalMAC----------00
BluetoothSerial/examples/SerialToSerialBT----------00
BluetoothSerial/examples/SerialToSerialBTM----------00
BluetoothSerial/examples/SerialToSerialBT_Legacy----------00
BluetoothSerial/examples/SerialToSerialBT_SSP----------00
BluetoothSerial/examples/bt_classic_device_discovery----------00
BluetoothSerial/examples/bt_remove_paired_devices----------00
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code----------00
ESP32/examples/Touch/TouchButton----------00
Ethernet/examples/ETH_LAN8720----------⚠️ +120⚠️ +24
Ethernet/examples/ETH_TLK110----------⚠️ +120⚠️ +24

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged labels May 28, 2024
@me-no-dev me-no-dev merged commit a4ee652 into master May 29, 2024
135 checks passed
@me-no-dev me-no-dev deleted the bugfix/netif_events_on_end branch May 29, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@me-no-dev @P-R-O-C-H-Y