Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(3rd party board): Adding ViraLink IoT Gate Boards #9841

Merged
merged 10 commits into from
Jun 25, 2024
Merged

feat(3rd party board): Adding ViraLink IoT Gate Boards #9841

merged 10 commits into from
Jun 25, 2024

Conversation

armp30
Copy link
Contributor

@armp30 armp30 commented Jun 12, 2024

Description of Change

feat(3rd party board): Adding ViraLink IoT Gate Boards

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core v3.0.1.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024 •
edited
Loading

Warnings
⚠️ Please consider squashing your 10 commits (simplifying branch history).

👋 Hello armp30, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 1852cd0

@me-no-dev
Copy link
Member

build.board must be uppercase

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Jun 13, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @me-no-dev commented, please change the build.board to uppercase.

@VojtechBartoska VojtechBartoska added the Resolution: Awaiting response Waiting for response of author label Jun 17, 2024
@me-no-dev
Copy link
Member

@armp30 no response for over a week? Would you please finish this? If no further response, we will close it.

@armp30
Copy link
Contributor Author

armp30 commented Jun 22, 2024 •
edited
Loading

@P-R-O-C-H-Y @me-no-dev fixed

@armp30 armp30 requested a review from P-R-O-C-H-Y June 22, 2024 16:48
P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armp30 Please fix the missing default SPI pins.

variants/ViraLink-G0.1/pins_arduino.h Show resolved Hide resolved
variants/ViraLink-G1.1/pins_arduino.h Show resolved Hide resolved
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Jun 25, 2024
@me-no-dev me-no-dev merged commit 09b30e9 into espressif:master Jun 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armp30 @me-no-dev @P-R-O-C-H-Y @VojtechBartoska