Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): Fix NetworkClient::localIP() #9845

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

me-no-dev
Copy link
Member

It was returning zero, because it was not able to handle IPv4 mapped address into IPv6 address

Fixes: #9843

It was returning zero, because it was not able to handle IPv4 mapped address into IPv6 address
Copy link
Contributor

github-actions bot commented Jun 12, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against eaa365c

Copy link
Contributor

github-actions bot commented Jun 12, 2024

Test Results

 56 files   56 suites   5m 11s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
135 runs  135 ✅ 0 💤 0 ❌

Results for commit eaa365c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Ethernet/examples/ETH_W5500_Arduino_SPI------------
Ethernet/examples/ETH_W5500_IDF_SPI------------
NetworkClientSecure/examples/WiFiClientInsecure------------
NetworkClientSecure/examples/WiFiClientPSK------------
NetworkClientSecure/examples/WiFiClientSecure------------
NetworkClientSecure/examples/WiFiClientSecureEnterprise------------
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade------------
NetworkClientSecure/examples/WiFiClientShowPeerCredentials------------
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse------------
PPP/examples/PPP_Basic------------
WebServer/examples/AdvancedWebServer------------
WebServer/examples/FSBrowser------------
WebServer/examples/HelloServer------------
WebServer/examples/HttpAdvancedAuth------------
WebServer/examples/HttpAuthCallback------------
WebServer/examples/HttpAuthCallbackInline------------
WebServer/examples/HttpBasicAuth------------
WebServer/examples/HttpBasicAuthSHA1------------
WebServer/examples/HttpBasicAuthSHA1orBearerToken------------
WebServer/examples/MultiHomedServers------------
WebServer/examples/PathArgServer------------
WebServer/examples/SDWebServer------------
WebServer/examples/SimpleAuthentification------------
WebServer/examples/UploadHugeFile------------
WebServer/examples/WebServer------------
WebServer/examples/WebUpdate------------
WiFi/examples/FTM/FTM_Initiator------------
WiFi/examples/FTM/FTM_Responder------------
WiFi/examples/SimpleWiFiServer------------
WiFi/examples/WPS------------
WiFi/examples/WiFiAccessPoint------------
WiFi/examples/WiFiBlueToothSwitch------------
WiFi/examples/WiFiClient------------
WiFi/examples/WiFiClientBasic------------
WiFi/examples/WiFiClientConnect------------
WiFi/examples/WiFiClientEnterprise------------
WiFi/examples/WiFiClientEvents------------
WiFi/examples/WiFiClientStaticIP------------
WiFi/examples/WiFiIPv6------------
WiFi/examples/WiFiMulti------------
WiFi/examples/WiFiMultiAdvanced------------
WiFi/examples/WiFiScan------------
WiFi/examples/WiFiScanAsync------------
WiFi/examples/WiFiScanDualAntenna------------
WiFi/examples/WiFiSmartConfig------------
WiFi/examples/WiFiTelnetToSerial------------
WiFi/examples/WiFiUDPClient------------
Ethernet/examples/ETH_LAN8720------------
Ethernet/examples/ETH_TLK110------------

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Jun 13, 2024
@me-no-dev me-no-dev merged commit 211520b into master Jun 13, 2024
74 checks passed
@me-no-dev me-no-dev deleted the bugfix/client_local_ip branch June 13, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetworkClient localIP() always returns IPAddress(0,0,0,0)
1 participant