Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wifi): Fix WiFi setTxPower and getTxPower #9862

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

me-no-dev
Copy link
Member

We need to wait for the interface to be started in order to be able to set/get TX Power. Code was returning too early, so calling the functions after begin() resulted in failure.

Fixes: #9858

We need to wait for the interface to be started in order to be able to set/get TX Power. Code was returning too early, so calling the functions after `begin()` resulted in failure.
Copy link
Contributor

github-actions bot commented Jun 14, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix(wifi): Fix WiFi setTxPower and getTxPower":
    • body's lines must not be longer than 100 characters

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 0f15260

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Jun 14, 2024
Copy link
Contributor

github-actions bot commented Jun 14, 2024

Test Results

 56 files   56 suites   5m 16s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
135 runs  135 ✅ 0 💤 0 ❌

Results for commit 0f15260.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
WiFi/examples/FTM/FTM_Initiator----------
WiFi/examples/FTM/FTM_Responder----------
WiFi/examples/SimpleWiFiServer----------
WiFi/examples/WPS----------
WiFi/examples/WiFiAccessPoint----------
WiFi/examples/WiFiBlueToothSwitch----------
WiFi/examples/WiFiClient----------
WiFi/examples/WiFiClientBasic----------
WiFi/examples/WiFiClientConnect----------
WiFi/examples/WiFiClientEnterprise----------
WiFi/examples/WiFiClientEvents----------
WiFi/examples/WiFiClientStaticIP----------
WiFi/examples/WiFiIPv6----------
WiFi/examples/WiFiMulti----------
WiFi/examples/WiFiMultiAdvanced----------
WiFi/examples/WiFiScan----------
WiFi/examples/WiFiScanAsync----------
WiFi/examples/WiFiScanDualAntenna----------
WiFi/examples/WiFiSmartConfig----------
WiFi/examples/WiFiTelnetToSerial----------
WiFi/examples/WiFiUDPClient----------

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jun 17, 2024
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@me-no-dev me-no-dev merged commit c43187a into master Jun 17, 2024
53 checks passed
@me-no-dev me-no-dev deleted the bugfix/wifi_tx_power branch June 17, 2024 19:47
@SuGlider SuGlider mentioned this pull request Jun 18, 2024
1 task
Copy link

@zebraonpc zebraonpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real Tx Power does not changed even if WiFi.getTxPower() shows correct power my esp32-s doesnt change output power it is always the same i measured it

@SuGlider
Copy link
Collaborator

The real Tx Power does not changed even if WiFi.getTxPower() shows correct power my esp32-s doesnt change output power it is always the same i measured it

I think that it not measuring the real Power, but just returning the setTxPower() value.

@zebraonpc
Copy link

The real Tx Power does not changed even if WiFi.getTxPower() shows correct power my esp32-s doesnt change output power it is always the same i measured it

I think that it not measuring the real Power, but just returning the setTxPower() value.

ergo the library doesnt really work correctly with the ESP32-S

@me-no-dev
Copy link
Member Author

All that Arduino does is call esp_wifi_set_max_tx_power(power). I suggest you as in the IDF repo and see if they have an idea why in reality power is not changed.

@TD-er
Copy link
Contributor

TD-er commented Jul 1, 2024

The real Tx Power does not changed even if WiFi.getTxPower() shows correct power my esp32-s doesnt change output power it is always the same i measured it

What were the TX power values you tried?
Please be aware the ESP cannot change to just any TX power value as there are only some discrete steps.
Also the max. TX power differs based on the type of connection you use.
e.g. 802.11b typically allows for higher TX power compared to 802.11n. (typically 20-ish vs. 13 or 14 dBm respectively, may change per ESP model)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WiFi.setTxPower() always return +19.5dBm
5 participants