-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wifi): Fix WiFi setTxPower and getTxPower #9862
Conversation
We need to wait for the interface to be started in order to be able to set/get TX Power. Code was returning too early, so calling the functions after `begin()` resulted in failure.
👋 Hello me-no-dev, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 56 files 56 suites 5m 16s ⏱️ Results for commit 0f15260. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The real Tx Power does not changed even if WiFi.getTxPower() shows correct power my esp32-s doesnt change output power it is always the same i measured it
I think that it not measuring the real Power, but just returning the setTxPower() value. |
ergo the library doesnt really work correctly with the ESP32-S |
All that Arduino does is call |
What were the TX power values you tried? |
We need to wait for the interface to be started in order to be able to set/get TX Power. Code was returning too early, so calling the functions after
begin()
resulted in failure.Fixes: #9858