-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientSecure.available() fix for connection closed by remote socket #9869
ClientSecure.available() fix for connection closed by remote socket #9869
Conversation
👋 Hello JAndrassy, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 56 files 56 suites 7m 6s ⏱️ For more details on these failures, see this check. Results for commit 714e32c. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|
https://www.arduino.cc/reference/en/language/functions/communication/stream/streamavailable/
many test it as boolean, as does the example from the NetworkClientSecure library used to test this PR |
49b4d21
to
714e32c
Compare
Will this be backported to 2.0.x also? |
we have no such plans. IDF 4.4. goes EOL next month. You are welcome to add PR and we will merge it though |
for connection closed by remote socket the
NetworkClientSecure.available()
method:The error logging is skipped for error code returned in this case. This error code is skipped in ssl_client.cpp
_handle_error
too.I tested it with modified WiFiClientInsecure example
without the fix it logged
the setSocketOption error and the strange character were the result of
read
which was executed because available() didn't return a 0 but a negative value.