Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(netbios): Return interface address for NetBIOS name lookup #9885

Merged
merged 3 commits into from
Jun 18, 2024
Merged

fix(netbios): Return interface address for NetBIOS name lookup #9885

merged 3 commits into from
Jun 18, 2024

Commits on Jun 18, 2024

  1. fix(netbios): Return interface address for NetBIOS 

    When NetBIOS returns a match, it should return the IP address of the device.
Presently, however, it returns the address of multicast IP for the subnet
since the incoming NBNS packet's UDP target will be multicast
(i.e. 192.168.1.255).

Iterate over the active network interfaces and check netmasks to determine
where the packet came from, and return the appropriate IP interface address
instead.
    @earlephilhower
    earlephilhower committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    9d8b43b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into nb1

    @earlephilhower
    earlephilhower committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b80c2e1 View commit details
    Browse the repository at this point in the history

  3. ci(pre-commit): Apply automatic fixes

    @pre-commit-ci-lite
    pre-commit-ci-lite[bot] committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    9832cfd View commit details
    Browse the repository at this point in the history