Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boards): set XTAL 26MHz for Heltec WiFi & LoRa V1 #9889

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

yoursunny
Copy link
Contributor

@yoursunny yoursunny commented Jun 18, 2024

Description of Change

For Heltec WiFi Kit 32 V1:

  • Change crystal frequency to 26MHz.
  • Add partition scheme menu.
  • Delete PSRAM menu.

For Heltec WiFi LoRa 32 V1:

  • Change crystal frequency to 26MHz.
  • Change flash size to 4MB.
  • Add partition scheme menu.

Tests scenarios

The changes were tested on above-mentioned boards.
I have used these examples:

  • ESP32/Serial/Serial_All_CPU_Freqs
  • FFat/FFat_Test
  • WiFi/WiFiScan

Related links

Heltec WiFi Kit 32 V1 schematic: https://resource.heltec.cn/download/WiFi_Kit_32/WIFI_Kit_32_Schematic_diagram_V1.PDF

  • The crystal is 26MHz.
  • If PSRAM exists, its CE signal would be connected on GPIO16, but the only thing connected on GPIO16 is the OLED display, so that PSRAM does not exist. Moreover, enabling PSRAM results in serial message indicating that PSRAM cannot be detected.

Heltec WiFi LoRa 32 V1 schematic: https://resource.heltec.cn/download/WiFi_LoRa_32/V1

  • The crystal is 26MHz.
  • The flash chip W25Q32FVSS is 32Mb i.e. 4MB.

closes #9867

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jun 18, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello yoursunny, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2a65e22

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Jun 18, 2024
@me-no-dev me-no-dev merged commit 3f6c34a into espressif:master Jun 19, 2024
18 checks passed
@yoursunny yoursunny deleted the heltec-xtal branch June 20, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32 WiFiScan: no networks found
5 participants