Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variant for Elecrow CrowPanel 7.0" #9897

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Jun 18, 2024

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

Add variant for Elecrow CrowPanel 7.0"

  • feat(esp32): Add variant for Elecrow CrowPanel 7.0"

Variant for https://www.elecrow.com/esp32-display-7-inch-hmi-display-rgb-tft-lcd-touch-screen-support-lvgl.html

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core 3.0.1 with Elecrow CrowPanel 7.0" with this scenario.

Related links

Fixes: #9895

Add variant for Elecrow CrowPanel 7.0"
Add variant for Elecrow CrowPanel 7.0"
Copy link
Contributor

github-actions bot commented Jun 18, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "* feat(esp32): Add variant for Elecrow CrowPanel 7.0":
    • summary looks empty
    • type/action looks empty
  • the commit message "* feat(esp32): Add variant for Elecrow CrowPanel 7.0":
    • summary looks empty
    • type/action looks empty
  • the commit message "* feat(esp32): Add variant for Elecrow CrowPanel 7.0":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello lboue, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 66f84dc

@lucasssvaz
Copy link
Collaborator

lucasssvaz commented Jun 18, 2024

Just a heads up, you dont need to close and open a new PR to update your files. Just push to the base branch that the pull request refers to.

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lboue Just small nitpicks ptal. Otherwise looking good.

boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
@VojtechBartoska VojtechBartoska added the Resolution: Awaiting response Waiting for response of author label Jun 19, 2024
@lboue
Copy link
Contributor Author

lboue commented Jun 19, 2024

@lboue Just small nitpicks ptal. Otherwise looking good.

It sould be OK with my last commit.

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Jun 19, 2024
@me-no-dev me-no-dev merged commit e7dd6e2 into espressif:master Jun 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Elecrow CrowPanel 7.0".
5 participants