PPP: Make modem reset delay configurable #9910
Conversation
|
|
👋 Hello tl-sl, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 56 files 56 suites 5m 19s ⏱️ Results for commit b5c2f70. ♻️ This comment has been updated with latest results. |
tl-sl
force-pushed
the
ppp-mode-reset-delay
branch
2 times, most recently
from
97a3c9a
to
f407853
Compare
The delay required to reset Simcom modem modules varies significantly across different models, even where they have otherwise identical AT command sets. Simcom A7672 was failing to reset with the default 200ms delay. Make the reset delay configurable to allow customising this for a specific modem. Default delay, if not specified is kept at 200ms.
tl-sl
force-pushed
the
ppp-mode-reset-delay
branch
from
f407853
to
b5c2f70
Compare
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
The delay required to reset Simcom modem modules varies significantly across different models, even where they have otherwise identical AT command sets.
Make the reset delay configurable to allow customising this for a specific modem.
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
Please describe your proposed Pull Request and it's impact.
The delay required to reset Simcom modem modules varies significantly across different models, even where they have otherwise identical AT command sets. Make this configurable, but keep the default at 200ms, which is the correct valaue for the Simcom 7600 model used in the example.
Tests scenarios
Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
Tested on Simcom A7672G module which requires 2500 ms delay. Modem resets correctly.
Related links
Please provide links to related issue, PRs etc.
Fixes: #9907