Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(i2s): Fix I2S documentation example #9916

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Fixes naming in I2S example to avoid conflicts.

Related links

Closes #9914

@lucasssvaz lucasssvaz added Type: Documentation Issue pertains to Documentation of Arduino ESP32 Type: Example Issue is related to specific example. labels Jun 21, 2024
@lucasssvaz lucasssvaz self-assigned this Jun 21, 2024
Copy link
Contributor

github-actions bot commented Jun 21, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against e4b7e10

@SuGlider SuGlider added the Status: Pending Merge Pull Request is ready to be merged label Jun 23, 2024
@SuGlider SuGlider self-requested a review June 23, 2024 19:43
@me-no-dev me-no-dev merged commit 1f2ba1f into espressif:master Jun 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: Documentation Issue pertains to Documentation of Arduino ESP32 Type: Example Issue is related to specific example.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP_I2S.h: error: 'int read' redeclared as different kind of entity
5 participants