Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(idf): Require openthread on H2 and C6 #9934

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

me-no-dev
Copy link
Member

Fixes IDF builds for H2 and C6 when OpenThread is enabled

Fixes IDF builds for H2 and C6 when OpenThread is enabled
Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against d2ee67e

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged 🚫 System PR Pull requests for internal use or lib updates labels Jun 25, 2024
@me-no-dev me-no-dev merged commit 777d0d7 into master Jun 25, 2024
11 checks passed
@me-no-dev me-no-dev deleted the bugfix/require_openthread branch June 25, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged 🚫 System PR Pull requests for internal use or lib updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant