Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(board): Add M5Stack NanoC6 Dev Kit #9942

Merged
merged 12 commits into from
Jul 16, 2024
Merged

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Jun 26, 2024

M5Stack NanoC6 Dev Kit
https://shop.m5stack.com/products/m5stack-nanoc6-dev-kit

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

add(board): Add M5Stack NanoC6 Dev Kit

Tests scenarios

Local testing with M5Stack NanoC6 Dev Kit.

Related links

https://shop.m5stack.com/products/m5stack-nanoc6-dev-kit

(eg. Closes #number of issue)

Copy link
Contributor

github-actions bot commented Jun 26, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Rename variants/m5stack_stickc_plus/m5stack_nanoc6/pins_arduino.h to variants/m5stack_nanoc6/pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "add(board): Add M5Stack NanoC6 Dev Kit":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "add(board): Add M5Stack NanoC6 Dev Kit":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "add(board): Add M5Stack NanoC6 Dev Kit":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "add(board): Add M5Stack NanoC6 Dev Kit":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 12 commits (simplifying branch history).
⚠️

The source branch "NanoC6" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello lboue, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 0d5e09c

@lboue lboue marked this pull request as ready for review June 26, 2024 20:52
@me-no-dev
Copy link
Member

@P-R-O-C-H-Y PTAL if I missed anything

@me-no-dev
Copy link
Member

@lboue would you please take care of the comments above?

@lboue
Copy link
Contributor Author

lboue commented Jul 8, 2024

I will do it ASAP

@lboue
Copy link
Contributor Author

lboue commented Jul 15, 2024

I will do it ASAP

@me-no-dev Done

@me-no-dev
Copy link
Member

@lboue thanks!

@P-R-O-C-H-Y PTAL

m5stack_nanoc6.build.board was not uppercase
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Jul 16, 2024
@me-no-dev me-no-dev merged commit 2db7306 into espressif:master Jul 16, 2024
13 checks passed
@lboue lboue deleted the NanoC6 branch October 13, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants