Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes WiFiProv.ino #9946

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Fixes WiFiProv.ino #9946

merged 3 commits into from
Jun 28, 2024

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Jun 27, 2024

Description of Change

Fixes WiFi Provisioning example to work with the new Network layer.
Adds a WiFi.begin() for automatic connection after provisioning or after reading NVS.
Changed the Provisioning mode to BLE in order to avoid a memory releasing problem with ESP32 after provisioning.

Tests scenarios

Tested with S3 and ESP32 using the example from
https://github.com/espressif/arduino-esp32/blob/master/libraries/WiFiProv/examples/WiFiProv/WiFiProv.ino

Related links

Fix #9943

@SuGlider SuGlider added the Area: BT&Wifi BT & Wifi related issues label Jun 27, 2024
@SuGlider SuGlider added this to the 3.0.3 milestone Jun 27, 2024
@SuGlider SuGlider self-assigned this Jun 27, 2024
Copy link
Contributor

github-actions bot commented Jun 27, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update WiFiProv.ino":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️

The source branch "SuGlider_WiFi_Prov_example" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.
Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9334014

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C30⚠️ +100.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP320⚠️ +40.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
WiFiProv/examples/WiFiProv0000⚠️ +10000⚠️ +40

Copy link
Contributor

github-actions bot commented Jun 27, 2024

Test Results

 56 files  ±0   56 suites  ±0   5m 19s ⏱️ +2s
 21 tests ±0   21 ✅ ±0  0 💤 ±0  0 ❌ ±0 
135 runs  ±0  135 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9334014. ± Comparison against base commit 4a6437d.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Jun 28, 2024
@me-no-dev me-no-dev merged commit 337058a into master Jun 28, 2024
40 checks passed
@me-no-dev me-no-dev deleted the SuGlider_WiFi_Prov_example branch June 28, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BT&Wifi BT & Wifi related issues Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

WifiProv BLE doesn't auto connect Wifi after initial provisioning
3 participants