Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): Add better WPS logging #9999

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix(example): Add better WPS logging #9999

merged 2 commits into from
Jul 10, 2024

Conversation

me-no-dev
Copy link
Member

Provides a better log of what went wrong when using WPS

Provides a better log of what went wrong when using WPS
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8f04425

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +3800.00⚠️ +0.04💚 -1840💚 -0.450.00
ESP32S20⚠️ +3840.00⚠️ +0.05💚 -1760💚 -0.480.00
ESP32C30⚠️ +3580.00⚠️ +0.04💚 -1760💚 -0.520.00
ESP32C60⚠️ +3660.00⚠️ +0.04💚 -1760💚 -0.460.00
ESP320⚠️ +3920.00⚠️ +0.04💚 -1760💚 -0.400.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
WiFi/examples/WPS⚠️ +380💚 -184⚠️ +384💚 -176⚠️ +358💚 -176⚠️ +366💚 -176⚠️ +392💚 -176

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Test Results

 56 files  ±0   56 suites  ±0   4m 55s ⏱️ -23s
 21 tests ±0   21 ✅ ±0  0 💤 ±0  0 ❌ ±0 
135 runs  ±0  135 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8f04425. ± Comparison against base commit 4e3523c.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Jul 10, 2024
@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jul 10, 2024
@me-no-dev me-no-dev merged commit 874e2a1 into master Jul 10, 2024
40 checks passed
@me-no-dev me-no-dev deleted the example/wps_log branch July 10, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants