Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update shields to link directly to desired website #37

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

peterdragun
Copy link
Collaborator

@peterdragun peterdragun commented Jan 2, 2025

Description

Before this fix, shields were linked to a new window with just a shield. A second click was needed to actually get to the desired website. This was annoying, so I decided to add a link directly from the shield without the additional click required

Related

No issues reported yet

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Before this fix, shields were linked to a new window with just a shield.
A second click was needed to actually get to the desired website.
@peterdragun peterdragun marked this pull request as ready for review January 2, 2025 13:46
@peterdragun peterdragun self-assigned this Jan 2, 2025
Copy link
Member

@tomassebestik tomassebestik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution, @peterdragun!

(I'm adding you to the project so that with your next contributions, you can create branches directly instead of forking.)

@tomassebestik tomassebestik merged commit 9e2c54c into espressif:master Jan 3, 2025
15 checks passed
@peterdragun peterdragun deleted the fix/shield_link branch January 3, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants