Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http_Stream resume behavior should restart at last read, not from beginning. (AUD-5571) #1239

Open
rwrozelle opened this issue Jul 25, 2024 · 2 comments

Comments

@rwrozelle
Copy link

Is your feature request related to a problem? Please describe.
Pausing and Resuming a pipeline causes the url being read to restart from beginning.

Describe the solution you'd like
Expected behavior would be for it to resume at same location the pause occurred, understand that this may need a "timeout" where if it waits that long, it closes the http connection and behavior reverts to what is happening now.

Describe alternatives you've considered
I have not.

Please give as many details as you can. Include suggestions for useful APIs or interfaces if relevant.
I've setup an audio pipeline http_stream_reader -> esp_encoder -> i2s_stream_writer. If I pause the pipeline and resume the pipeline, it starts over.

@github-actions github-actions bot changed the title Http_Stream resume behavior should restart at last read, not from beginning. Http_Stream resume behavior should restart at last read, not from beginning. (AUD-5571) Jul 25, 2024
@jason-mao
Copy link
Collaborator

@rwrozelle The pipeline pause will close the element, resume is restart, refer to

audio_element_process_deinit(el);
. I suggest you call the element_pause to pause i2s_stream_writer element only, do not use the pipeline_pause.

@rwrozelle
Copy link
Author

rwrozelle commented Jul 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants